GH-36773: [C++][Parquet] Avoid calculating prebuffer column bitmap multiple times #36774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
mapleFU
commented
Jul 19, 2023
github-actions
bot
added
awaiting committer review
mapleFU
force-pushed
the
parquet/avoid-multiple-count-bitmap
branch
from
8a43f41
to
c8e226b
Compare
|
Also cc @jp0317 |
mapleFU
force-pushed
the
parquet/avoid-multiple-count-bitmap
branch
from
c8e226b
to
a4208e4
Compare
|
I wonder that if https://github.com/apache/arrow/pull/36774/files#r1268338192 is possible. Because I guess if no selection or projection, there are all-buffered. Should I do an optimization for all-buffered case, using a |
wgtmac
approved these changes
Jul 20, 2023
|
@pitrou would mind take a look? This patch is small and simple |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b31977f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…map multiple times (apache#36774) ### Rationale for this change According to apache#36192 and apache#36649 . RowGroupReader using a bitmap to control a column-level prebuffer. However, if all columns are selected, this will be a heavy overhead for building a bitmap multiple times. ### What changes are included in this PR? Build `Prebuffer` Bitmap once, and reuse that vector. ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: apache#36773 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…map multiple times (apache#36774) ### Rationale for this change According to apache#36192 and apache#36649 . RowGroupReader using a bitmap to control a column-level prebuffer. However, if all columns are selected, this will be a heavy overhead for building a bitmap multiple times. ### What changes are included in this PR? Build `Prebuffer` Bitmap once, and reuse that vector. ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: apache#36773 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
According to #36192 and #36649 . RowGroupReader using a bitmap to control a column-level prebuffer.
However, if all columns are selected, this will be a heavy overhead for building a bitmap multiple times.
What changes are included in this PR?
Build
PrebufferBitmap once, and reuse that vector.Are these changes tested?
no
Are there any user-facing changes?
no