Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36839: [CI][Docs] Update test-ubuntu-default-docs to use GitHub actions instead of Azure #36840

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 24, 2023

Rationale for this change

Currently test-ubuntu-default-docs has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation.
Using the same base action for both preview-docs, test and packaging will improve maintainability.

What changes are included in this PR?

Move test-ubuntu-default-docs to use GH actions instead of Azure.

Are these changes tested?

Yes, with archery related tasks.

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Jul 24, 2023

@github-actions crossbow submit test-ubuntu-default-docs

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 24, 2023
@raulcd
Copy link
Member Author

raulcd commented Jul 24, 2023

@github-actions crossbow submit preview-docs

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jul 24, 2023

@github-actions crossbow submit test-ubuntu-default-docs

@github-actions
Copy link

Revision: 5277737

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c4e6ae8e9

Task Status
test-ubuntu-default-docs Github Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 24, 2023

@github-actions crossbow submit preview-docs

@raulcd raulcd marked this pull request as ready for review July 24, 2023 12:17
@github-actions
Copy link

Revision: 5277737

Submitted crossbow builds: ursacomputing/crossbow @ actions-a223edc8a5

Task Status
preview-docs Github Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

params:
artifacts: "build/docs.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this to validate uploaded artifacts (archery crossbow --validate) after uploading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't line 1445 below for that:

    artifacts:
      - docs.tar.gz

I think this was unused but I might be confused.
The validation seems correct on the job triggered via crossbow: https://github.com/ursacomputing/crossbow/actions/runs/5643790115/job/15286296284#step:14:24

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! You're right!

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting merge Awaiting merge labels Jul 24, 2023
@kou kou merged commit 06deded into apache:main Jul 25, 2023
10 checks passed
@kou kou removed the awaiting changes Awaiting changes label Jul 25, 2023
raulcd added a commit that referenced this pull request Jul 25, 2023
…tions instead of Azure (#36840)

### Rationale for this change

Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation.
Using the same base action for both preview-docs, test and packaging will improve maintainability.

### What changes are included in this PR?

Move `test-ubuntu-default-docs` to use GH actions instead of Azure.

### Are these changes tested?

Yes, with archery related tasks.

### Are there any user-facing changes?

No
* Closes: #36839

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 06deded.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
…Hub actions instead of Azure (apache#36840)

### Rationale for this change

Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation.
Using the same base action for both preview-docs, test and packaging will improve maintainability.

### What changes are included in this PR?

Move `test-ubuntu-default-docs` to use GH actions instead of Azure.

### Are these changes tested?

Yes, with archery related tasks.

### Are there any user-facing changes?

No
* Closes: apache#36839

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…Hub actions instead of Azure (apache#36840)

### Rationale for this change

Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation.
Using the same base action for both preview-docs, test and packaging will improve maintainability.

### What changes are included in this PR?

Move `test-ubuntu-default-docs` to use GH actions instead of Azure.

### Are these changes tested?

Yes, with archery related tasks.

### Are there any user-facing changes?

No
* Closes: apache#36839

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Docs] test-ubuntu-default-docs fails with no space left on device
2 participants