New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3693
Changes from all commits
219384f
aad43b2
695bdc9
a24285b
057347a
9c1d6e4
3a0620f
e0058b2
5b904fa
4cb63b1
aa9f711
f2e4dfa
e69b1e9
41ae266
2ee894f
e56dd14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -301,13 +301,24 @@ arrow_add_pkg_config("arrow") | |
# | ||
|
||
add_arrow_test(allocator-test) | ||
add_arrow_test(array-test | ||
SOURCES | ||
array-test.cc | ||
array-binary-test.cc | ||
array-dict-test.cc | ||
array-list-test.cc | ||
array-struct-test.cc) | ||
|
||
if(WIN32) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @javierluraschi @kou In the future, please add a comment when you add a special case like this, so that we know why it is there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. Sorry for this. |
||
add_arrow_test(array-test | ||
SOURCES | ||
array-test.cc | ||
array-binary-test.cc | ||
array-list-test.cc | ||
array-struct-test.cc) | ||
else() | ||
add_arrow_test(array-test | ||
SOURCES | ||
array-test.cc | ||
array-binary-test.cc | ||
array-dict-test.cc | ||
array-list-test.cc | ||
array-struct-test.cc) | ||
endif() | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is it needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know, I wasn't able to reproduce this one on my local MinGW 32-bit environment, but let me disable it and hopefully your new test command will output something in appveyor that can point us in the right direction. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alright, so from AppVeyor, looks like this is causing:
Which again, I can't repro locally. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me re-skip this test to have them back at passing... My suggestion would be to merge with a couple tests skipped and then open JIRA issues to investigate further. Otherwise, the longer it take us to merge this PR, the more likely something else will break Windows. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you open an issue on JIRA to work this on another pull request? |
||
add_arrow_test(buffer-test) | ||
|
||
if(ARROW_IPC) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,7 +110,11 @@ static inline uint32_t SSE4_crc32_u32(uint32_t crc, uint32_t v) { | |
} | ||
|
||
static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) { | ||
#if ARROW_BITNESS == 32 | ||
return 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would expect a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aborting with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this introduced the following build error, so reverted the change:
Unfortunately, this build error does not reproduce in my local environment and further information is not available in appveyor. |
||
#else | ||
return static_cast<uint32_t>(_mm_crc32_u64(crc, v)); | ||
#endif | ||
} | ||
|
||
#else // without SSE 4.2. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
Could you show details of the error by resolving this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou, sure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
The following patch will solve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you set PYTHONHOME you shouldn't have to set PYTHONPATH as well. Python will infer the path automatically from PYTHONHOME.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try that, give me a sec...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the original suggestion breaks the build, see https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/22735113/job/y7dijp1ym0y1q87g, which triggers:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't resolve without
PYTHONPATH
on local:With
PYTHONPATH
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to set environment variables for Python only around testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to work this on another pull request, could you open an issue on JIRA?