Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36969: [C++][R] Bump abseil-cpp version #37066

Closed
wants to merge 8 commits into from

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Aug 8, 2023

Rationale for this change

Our current version of abseil-cpp fails to build with gcc 13 which is used on CRAN machines.

Are these changes tested?

CI

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

⚠️ GitHub issue #36969 has been automatically assigned in GitHub to PR creator.

@assignUser
Copy link
Member Author

@github-actions crossbow submit -g cpp -g r

@assignUser assignUser modified the milestone: 13.0.0 Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Revision: 8edb066

Submitted crossbow builds: ursacomputing/crossbow @ actions-5c039443fa

Task Status
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-r41 Azure
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions
r-binary-packages Github Actions
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-dev-duckdb Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-gcc-12 Github Actions
test-r-install-local Github Actions
test-r-install-local-minsizerel Github Actions
test-r-library-r-base-latest Azure
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rstudio-r-base-4.1-opensuse153 Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 Github Actions
test-r-versions Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-minimal-with-formats Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions
test-ubuntu-22.04-cpp-20 Github Actions
test-ubuntu-r-sanitizer Azure

@h-vetinari
Copy link
Contributor

Just a note that you need to be careful with abseil which C++ standard version you're using, as the ABI is affected by that choice (and you might e.g. run into missing symbols if one part is compiled with C++11 and one with C++17).

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages test-fedora-35-cpp

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Revision: 00986bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-08314a188d

Task Status
r-binary-packages Github Actions
test-fedora-35-cpp Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages test-fedora-35-cpp

@github-actions
Copy link

Revision: e1de598

Submitted crossbow builds: ursacomputing/crossbow @ actions-28e37993e0

Task Status
r-binary-packages Github Actions
test-fedora-35-cpp Github Actions

Comment on lines +26 to +27
ARROW_ABSL_BUILD_VERSION=20230125.3
ARROW_ABSL_BUILD_SHA256_CHECKSUM=5366d7e7fa7ba0d915014d387b66d0d002c03236448e1ba9ef98122c13b35c36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI, abseil very recently released a new LTS version.

Not sure if you're interested in upgrading this quickly, but presumably that'd mean you'd save half a year until the next abseil bump

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 11, 2023
@assignUser assignUser closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][R] abseil fails to build with gcc-13
3 participants