GH-37110: [C++] Expression: SmallestTypeFor lost tz for Scalar #37135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
reviewed
Aug 14, 2023
| cmp(field_ref("ts_s"), | ||
| literal(std::make_shared<TimestampScalar>(0, TimeUnit::NANO, "UTC"))), | ||
| cmp(field_ref("ts_s"), | ||
| literal(std::make_shared<TimestampScalar>(0, TimeUnit::SECOND, "UTC")))); |
There was a problem hiding this comment.
Since we are at it and the original PR didn't add many tests, can we also test non-zero values? For example (untested):
Suggested change
| literal(std::make_shared<TimestampScalar>(0, TimeUnit::SECOND, "UTC")))); | |
| literal(std::make_shared<TimestampScalar>(0, TimeUnit::SECOND, "UTC")))); | |
| ExpectBindsTo( | |
| cmp(field_ref("ts_s"), | |
| literal(std::make_shared<TimestampScalar>(123000, TimeUnit::NANO, "UTC"))), | |
| cmp(field_ref("ts_s"), | |
| literal(std::make_shared<TimestampScalar>(123, TimeUnit::MICRO, "UTC")))); |
There was a problem hiding this comment.
Added, I also found that we need a UTC type here.
field("ts_s_utc", timestamp(TimeUnit::SECOND, "UTC"))
github-actions
bot
added
awaiting committer review
pitrou
approved these changes
Aug 14, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit baf3eb9. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
Great find! |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#37135) ### Rationale for this change This patch ( apache#15180 ) adds a `SmallestTypeFor` to handling expression type. However, it lost timezone when handling. ### What changes are included in this PR? Add `timezone` in `SmallestTypeFor` ### Are these changes tested? Currently not ### Are there any user-facing changes? Yeah it's a bugfix * Closes: apache#37110 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This patch ( #15180 ) adds a
SmallestTypeForto handling expression type. However, it lost timezone when handling.What changes are included in this PR?
Add
timezoneinSmallestTypeForAre these changes tested?
Currently not
Are there any user-facing changes?
Yeah it's a bugfix