GH-37181: [MATLAB] Remove outdated test class tArrowCppCall.m
#37185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
+1 |
kevingurney
approved these changes
Aug 15, 2023
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f3dec5c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…apache#37185) ### Rationale for this change Now that `featherread` and `featherwrite` have been re-implemented in terms of the new APIs (`matlab.internal.io.feather.Reader` in apache#37046 and `matlab.io.internal.feather.Writer` in apache#37045), we can start removing the MEX code. To avoid submitting a large pull request, we should break the work down into several smaller, incremental steps. The first step should involve deleting the outdated test class `tArrowCppCall.m`. This test class will no longer be relevant once the MEX source code is removed. ### What changes are included in this PR? 1. Deleted the outdated test class `tArrowCppCall.m` ### Are these changes tested? No tests necessary. ### Are there any user-facing changes? No. ### Future Directions 1. Move the test cases in `test/tfeathermex.m` to `test/arrow/internal/io/feather/tRoundtrip.m`. These test cases directly call the MEX functions, so we will re-write the tests to utilize the `arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer` classes directly. 2. Delete `test/arrow/util/createVariablesAndMetadataStruct.m` 3. Delete `test/arrow/util/createTable.m` 4. Delete `test/arrow/util/featherMEXRoundTrip.m` 5. Delete `test/arrow/util/featherRoundTrip.m` 6. Remove MEX source code. * Closes: apache#37181 Authored-by: Sarah Gilmore <sgilmore@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Now that
featherreadandfeatherwritehave been re-implemented in terms of the new APIs (matlab.internal.io.feather.Readerin #37046 andmatlab.io.internal.feather.Writerin #37045), we can start removing the MEX code. To avoid submitting a large pull request, we should break the work down into several smaller, incremental steps.The first step should involve deleting the outdated test class
tArrowCppCall.m. This test class will no longer be relevant once the MEX source code is removed.What changes are included in this PR?
tArrowCppCall.mAre these changes tested?
No tests necessary.
Are there any user-facing changes?
No.
Future Directions
test/tfeathermex.mtotest/arrow/internal/io/feather/tRoundtrip.m. These test cases directly call the MEX functions, so we will re-write the tests to utilize thearrow.internal.io.feather.Readerandarrow.internal.io.feather.Writerclasses directly.test/arrow/util/createVariablesAndMetadataStruct.mtest/arrow/util/createTable.mtest/arrow/util/featherMEXRoundTrip.mtest/arrow/util/featherRoundTrip.mtArrowCppCall.m#37181