Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37239: [Ruby] Updated documentation for ArrowTable#initialize to clarify argument details #37261

Merged
merged 1 commit into from
Aug 20, 2023
Merged

GH-37239: [Ruby] Updated documentation for ArrowTable#initialize to clarify argument details #37261

merged 1 commit into from
Aug 20, 2023

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Aug 19, 2023 •
edited by kou

What changes are included in this PR?

Fixed the documentation for ArrowTable#initialize about the followings

  • initialize(schema, record_batches)
  • initialize(schema, raw_records)

@otegami otegami requested a review from kou as a code owner August 19, 2023 06:45
@github-actions
Copy link

⚠️ GitHub issue #37239 has been automatically assigned in GitHub to PR creator.

@otegami otegami mentioned this pull request Aug 19, 2023
Closed
kou
kou approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you use our PR template instead of removing it entirely next time?

@kou kou merged commit 6357c9f into apache:main Aug 20, 2023
10 checks passed
@kou kou removed the awaiting review Awaiting review label Aug 20, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 20, 2023
@otegami otegami deleted the fix-doc-about-arrow-table-initialize branch August 20, 2023 22:44
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6357c9f.

There were 4 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@otegami
Copy link
Contributor Author

otegami commented Aug 21, 2023

I'm so sorry. Next time I will keep the PR template without removing it.🙏

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@otegami @loicalleyne
apacheGH-37239: [Ruby] Updated documentation for ArrowTable#initializ…
0bf5f92 
…e to clarify argument details (apache#37261)

### What changes are included in this PR?
Fixed the documentation for ArrowTable#initialize about the followings
- initialize(schema, record_batches)
- initialize(schema, raw_records)

* Closes: apache#37239

Authored-by: otegami <a.s.takuya1026@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ruby] Arrow::Table#initialize's raw_records document is wrong
2 participants
@otegami @kou