Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37307: [Python][CI] Manually skip tests with skip_with_pyarrow_strings marker for nightly dask integration tests #37324

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 23, 2023

Rationale for this change

Dask added some tests with a custom @pytest.mark.skip_with_pyarrow_strings mark, which ensures to skip some tests when pyarrow is installed. However, that skip doesn't work correctly when running the tests on an installed version of dask with pytest --pyargs dask.tests.
Therefore manually skipping tests with that mark as a workaround.

…ow_strings marker for nightly dask integration tests
@github-actions
Copy link

⚠️ GitHub issue #37307 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 23, 2023
@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel

@github-actions
Copy link

Revision: 393ad32

Submitted crossbow builds: ursacomputing/crossbow @ actions-b710e26fea

Task Status
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel

@github-actions
Copy link

Revision: 604b70c

Submitted crossbow builds: ursacomputing/crossbow @ actions-37b5842388

Task Status
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel

@github-actions
Copy link

Revision: 950934a

Submitted crossbow builds: ursacomputing/crossbow @ actions-6afdafda3e

Task Status
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions

@jorisvandenbossche jorisvandenbossche merged commit c927520 into apache:main Aug 24, 2023
9 of 11 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Aug 24, 2023
@jorisvandenbossche jorisvandenbossche deleted the dask-nightly-string-failure branch August 24, 2023 19:33
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c927520.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…ow_strings marker for nightly dask integration tests (apache#37324)

### Rationale for this change

Dask added some tests with a custom `@ pytest.mark.skip_with_pyarrow_strings` mark, which ensures to skip some tests when pyarrow is installed. However, that skip doesn't work correctly when running the tests on an installed version of dask with `pytest --pyargs dask.tests`. 
Therefore manually skipping tests with that mark as a workaround.

* Closes: apache#37307

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][CI] Dask integration tests are failing for tests that should be skipped with pyarrow strings
1 participant