Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37639: [CI] Fix checkout on older OSes #37640

Merged
merged 5 commits into from
Sep 13, 2023
Merged

GH-37639: [CI] Fix checkout on older OSes #37640

merged 5 commits into from
Sep 13, 2023

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Sep 9, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Jobs are failing due to not being supported by node 20

What changes are included in this PR?

Using v3 where needed.

Are these changes tested?

Crossbow

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

⚠️ GitHub issue #37639 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 9, 2023
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions

This comment was marked as outdated.

Sign in to view
raulcd
raulcd reviewed Sep 9, 2023
View reviewed changes
dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Sep 9, 2023
@assignUser
Copy link
Member Author

assignUser commented Sep 11, 2023 •
edited
Loading

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 11, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
assignUser
assignUser commented Sep 11, 2023
View reviewed changes
dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@github-actions

This comment was marked as outdated.

Sign in to view
assignUser
assignUser commented Sep 11, 2023
View reviewed changes
dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@github-actions
Copy link

Revision: c838b84

Submitted crossbow builds: ursacomputing/crossbow @ actions-e79c6af781

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

Failures are unrelated (#37610 )

@kou
Copy link
Member

kou commented Sep 12, 2023

Could you rebase on main?

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions
Copy link

Revision: f800a2d

Submitted crossbow builds: ursacomputing/crossbow @ actions-4024a906b8

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

New, exciting erros 😁 but still unrelated

raulcd
raulcd approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Are we tracking the existing CI errors on an opened issue?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Sep 12, 2023
@assignUser
Copy link
Member Author

I created one: #37685 and the other one seems to be this issue previously happening on windows? #29563

@raulcd raulcd merged commit 4fac528 into apache:main Sep 13, 2023
7 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Sep 13, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4fac528.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@assignUser @raulcd @loicalleyne
apacheGH-37639: [CI] Fix checkout on older OSes (apache#37640)
0120b10 
### Rationale for this change

Jobs are failing due to not being supported by node 20

### What changes are included in this PR?

Using v3 where needed.

### Are these changes tested?

Crossbow
* Closes: apache#37639

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@assignUser @raulcd @dgreiss
apacheGH-37639: [CI] Fix checkout on older OSes (apache#37640)
385854a 
### Rationale for this change

Jobs are failing due to not being supported by node 20

### What changes are included in this PR?

Using v3 where needed.

### Are these changes tested?

Crossbow
* Closes: apache#37639

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

@kou kou Awaiting requested review from kou kou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] actions/checkout@v4 breaks on older OSes due to node 20
3 participants
@assignUser @kou @raulcd