GH-37750: [R][C++] Add compatability with IntelLLVM #37781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required for cmake >=3.20 otherwise the ID will be Intel
|
|
assignUser
changed the title
kou
approved these changes
Sep 19, 2023
github-actions
bot
added
awaiting merge
If there was any user request/bug reports for it but we only found this due to a synthetic test on CRAN so I don't really think that is worth the effort and cost(in ci time) at the moment. AFAIK we don't even have a job for classic Intel compiler... |
h-vetinari
reviewed
Sep 19, 2023
Comment on lines
+332
to
+333
| elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel" OR CMAKE_CXX_COMPILER_ID STREQUAL | ||
| "IntelLLVM") |
There was a problem hiding this comment.
The code further up in the diff is using a regex-match already; would make this a bit easier I guess...
Suggested change
| elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel" OR CMAKE_CXX_COMPILER_ID STREQUAL | |
| "IntelLLVM") | |
| elseif(CMAKE_CXX_COMPILER_ID MATCHES "^Intel(LLVM)?$") |
There was a problem hiding this comment.
I hope you don't mind, but I'm going to merge the PR as I need it to cherry-pick into an R package release I'm doing today, but we could make this change in a follow-up PR.
github-actions
bot
added
awaiting changes
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Sep 20, 2023
### Rationale for this change The IntelLLVM compiler has a different compiler ID that we currently can't handle and causes the build to fail. ### What changes are included in this PR? This adds the missing flags/IDs. Mimalloc in the current bundled version is not compatible with IntelLLVM this can be worked around by using a system version, a simple version bump is not sufficient and I don't think it's worth the effort to fix it properly for now. For the R package build I have disabled mimalloc with IntelLLVM to avoid issues on CRAN. * Closes: apache#37750 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Nic Crane <thisisnic@gmail.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fecb968. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change The IntelLLVM compiler has a different compiler ID that we currently can't handle and causes the build to fail. ### What changes are included in this PR? This adds the missing flags/IDs. Mimalloc in the current bundled version is not compatible with IntelLLVM this can be worked around by using a system version, a simple version bump is not sufficient and I don't think it's worth the effort to fix it properly for now. For the R package build I have disabled mimalloc with IntelLLVM to avoid issues on CRAN. * Closes: apache#37750 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The IntelLLVM compiler has a different compiler ID that we currently can't handle and causes the build to fail. ### What changes are included in this PR? This adds the missing flags/IDs. Mimalloc in the current bundled version is not compatible with IntelLLVM this can be worked around by using a system version, a simple version bump is not sufficient and I don't think it's worth the effort to fix it properly for now. For the R package build I have disabled mimalloc with IntelLLVM to avoid issues on CRAN. * Closes: apache#37750 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The IntelLLVM compiler has a different compiler ID that we currently can't handle and causes the build to fail.
What changes are included in this PR?
This adds the missing flags/IDs. Mimalloc in the current bundled version is not compatible with IntelLLVM this can be worked around by using a system version, a simple version bump is not sufficient and I don't think it's worth the effort to fix it properly for now.
For the R package build I have disabled mimalloc with IntelLLVM to avoid issues on CRAN.
Unknown compiler: IntelLLVM 2023.2.0#37750