Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4072: [Rust] Set default value for PARQUET_TEST_DATA #3783

Closed
wants to merge 1 commit into from
Closed

ARROW-4072: [Rust] Set default value for PARQUET_TEST_DATA #3783

wants to merge 1 commit into from

Conversation

ntrinquier
Copy link

No description provided.

let mut pathbuf = match env::var("PARQUET_TEST_DATA") {
Ok(path) => PathBuf::from_str(path.as_str()).unwrap(),
Err(_) => {
let mut pathbuf = env::current_dir().unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to allow for running from the root arrow directory (arrow) or the sub-crates (i.e. arrow\parquet) due to the use of work spaces. So the number of pops would need to be adjusted, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that regardless of where I run it from, the current directory is always arrow/rust/parquet (so the number of .pop() is constant).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paddyhoran You've used \ as delimiter, do you use Windows? If so, I'd appreciate if you could test the code locally :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I’m on windows. I’ll test locally tonight and report back.

Copy link
Contributor

@paddyhoran paddyhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows locally, works fine as is. Thanks @ntrinquier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants