GH-38007: [C++] Add VariableShapeTensor implementation #38008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Python
Component: Documentation
awaiting committer review
rok
force-pushed
the
38007
branch
2 times, most recently
from
eec16ec
to
6287402
Compare
rok
force-pushed
the
38007
branch
2 times, most recently
from
dff5441
to
9c3b464
Compare
|
Hi @rok! It would be great to have this in 15.0.0 (added the milestone for visibility). Do you think you have enough bandwidth to work on it at the moment? |
|
@AlenkaF yes I'd very much like to continue working on this, I was waiting for the release before chasing reviewers :D |
rok
commented
Nov 23, 2023
github-actions
bot
added
awaiting changes
pitrou
reviewed
Nov 27, 2023
github-actions
bot
added
awaiting change review
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
rok
force-pushed
the
38007
branch
2 times, most recently
from
1bb783e
to
63265dc
Compare
|
@pitrou any time to spare for a review here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want to add VariableShapeTensor extension type definition for arrays containing tensors with variable shapes.
What changes are included in this PR?
This adds a C++ implementation.
Are these changes tested?
Yes.
Are there any user-facing changes?
This adds a new extension type C++.