GH-38198: [Go] Fix AuthenticateBasicToken to be reliable behind proxies #38199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zeroshade
approved these changes
Oct 11, 2023
github-actions
bot
added
awaiting merge
llama90
pushed a commit
to llama90/arrow
that referenced
this pull request
Oct 12, 2023
… proxies (apache#38199) ### Rationale for this change Fixes a bug in the Go Flight client library that makes using AuthenticateBasicToken unreliable behind proxies. ### What changes are included in this PR? Closes the sending side of the bi-directional stream for the Flight Handshake RPC call before trying to read the headers. This matches the C++ implementation. <img width="609" alt="Screenshot 2023-10-11 at 6 18 40 PM" src="https://github.com/apache/arrow/assets/879445/05e23c6a-0ff8-41fc-825b-8add7fe938bc"> ### Are these changes tested? I've tested these changes against my service deployed behind CloudFlare and verified the error listed in the linked issue disappears. ### Are there any user-facing changes? No * Closes: apache#38198 Authored-by: Phillip LeBlanc <phillip@leblanc.tech> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 96d09e1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
… proxies (apache#38199) ### Rationale for this change Fixes a bug in the Go Flight client library that makes using AuthenticateBasicToken unreliable behind proxies. ### What changes are included in this PR? Closes the sending side of the bi-directional stream for the Flight Handshake RPC call before trying to read the headers. This matches the C++ implementation. <img width="609" alt="Screenshot 2023-10-11 at 6 18 40 PM" src="https://github.com/apache/arrow/assets/879445/05e23c6a-0ff8-41fc-825b-8add7fe938bc"> ### Are these changes tested? I've tested these changes against my service deployed behind CloudFlare and verified the error listed in the linked issue disappears. ### Are there any user-facing changes? No * Closes: apache#38198 Authored-by: Phillip LeBlanc <phillip@leblanc.tech> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
… proxies (apache#38199) ### Rationale for this change Fixes a bug in the Go Flight client library that makes using AuthenticateBasicToken unreliable behind proxies. ### What changes are included in this PR? Closes the sending side of the bi-directional stream for the Flight Handshake RPC call before trying to read the headers. This matches the C++ implementation. <img width="609" alt="Screenshot 2023-10-11 at 6 18 40 PM" src="https://github.com/apache/arrow/assets/879445/05e23c6a-0ff8-41fc-825b-8add7fe938bc"> ### Are these changes tested? I've tested these changes against my service deployed behind CloudFlare and verified the error listed in the linked issue disappears. ### Are there any user-facing changes? No * Closes: apache#38198 Authored-by: Phillip LeBlanc <phillip@leblanc.tech> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… proxies (apache#38199) ### Rationale for this change Fixes a bug in the Go Flight client library that makes using AuthenticateBasicToken unreliable behind proxies. ### What changes are included in this PR? Closes the sending side of the bi-directional stream for the Flight Handshake RPC call before trying to read the headers. This matches the C++ implementation. <img width="609" alt="Screenshot 2023-10-11 at 6 18 40 PM" src="https://github.com/apache/arrow/assets/879445/05e23c6a-0ff8-41fc-825b-8add7fe938bc"> ### Are these changes tested? I've tested these changes against my service deployed behind CloudFlare and verified the error listed in the linked issue disappears. ### Are there any user-facing changes? No * Closes: apache#38198 Authored-by: Phillip LeBlanc <phillip@leblanc.tech> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes a bug in the Go Flight client library that makes using AuthenticateBasicToken unreliable behind proxies.
What changes are included in this PR?
Closes the sending side of the bi-directional stream for the Flight Handshake RPC call before trying to read the headers. This matches the C++ implementation.
Are these changes tested?
I've tested these changes against my service deployed behind CloudFlare and verified the error listed in the linked issue disappears.
Are there any user-facing changes?
No