GH-34890: [C++][Python] Add a no-op kernel for dictionary_encode(dictionary) #38349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Python
Component: Documentation
labels
bkietz
requested changes
Oct 26, 2023
github-actions
bot
added
awaiting changes
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
github-actions
bot
added
awaiting change review
jorisvandenbossche
approved these changes
Oct 27, 2023
github-actions
bot
added
awaiting merge
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
bkietz
approved these changes
Oct 27, 2023
|
@jorisvandenbossche @bkietz Hi guys, would you mind merging this PR? |
|
Sorry, lost track of this |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit e502728. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
…e(dictionary) (apache#38349) Added a no-op kernel for convenience as discussed in the issue. * Closes: apache#34890 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…e(dictionary) (apache#38349) Added a no-op kernel for convenience as discussed in the issue. * Closes: apache#34890 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e(dictionary) (apache#38349) Added a no-op kernel for convenience as discussed in the issue. * Closes: apache#34890 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a no-op kernel for convenience as discussed in the issue.