GH-38351: [C#] Add SqlDecimal support to Decimal128Array #38481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CurtHagenlocher
commented
Oct 26, 2023
github-actions
bot
added
awaiting committer review
davidhcoe
reviewed
Oct 27, 2023
|
looks good after adding the tests |
|
r-project.org is down, causing the Docker build to fail. If it doesn't come back reasonably soon, I may commit anyway. |
|
The good news for me is that the unrelated build failure gave me more time to think about the code I thought was wrong and to come up with a test which showed that it indeed was wrong... . |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1633f8d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
CurtHagenlocher
pushed a commit
to apache/arrow-adbc
that referenced
this pull request
Oct 31, 2023
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses #1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
vleslief-ms
pushed a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 9, 2023
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…e#38481) ### What changes are included in this PR? Adds support for reading and writing System.Data.SqlTypes.SqlDecimal against Decimal128Array. ### Are these changes tested? Yes. ### Are there any user-facing changes? Adds functions to the API. * Closes: apache#38351 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
vleslief-ms
pushed a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 15, 2023
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e#38481) ### What changes are included in this PR? Adds support for reading and writing System.Data.SqlTypes.SqlDecimal against Decimal128Array. ### Are these changes tested? Yes. ### Are there any user-facing changes? Adds functions to the API. * Closes: apache#38351 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Adds support for reading and writing System.Data.SqlTypes.SqlDecimal against Decimal128Array.
Are these changes tested?
Yes.
Are there any user-facing changes?
Adds functions to the API.