Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38591: [Parquet][C++] Remove redundant open calls in ParquetFileFormat::GetReaderAsync #38621

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

eeroel
Copy link
Contributor

@eeroel eeroel commented Nov 7, 2023

Rationale for this change

There were duplicate method calls causing extra I/O operations, apparently unintentional from 0793432.

What changes are included in this PR?

Remove the extra method calls.

Are these changes tested?

Are there any user-facing changes?

Copy link

github-actions bot commented Nov 7, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@eeroel eeroel changed the title [GH-38591]: [Parquet] Remove redundant open calls GH-38591: [Parquet] Remove redundant open calls Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

⚠️ GitHub issue #38591 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member

mapleFU commented Nov 7, 2023

Will merge in one day if don't have any further comments

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 7, 2023
@mapleFU
Copy link
Member

mapleFU commented Nov 7, 2023

Also cc @raulcd would this better in 14.0.1?

@raulcd
Copy link
Member

raulcd commented Nov 7, 2023

Also cc @raulcd would this better in 14.0.1?

14.0.1 is frozen and ready to be shipped

@mapleFU mapleFU changed the title GH-38591: [Parquet] Remove redundant open calls GH-38591: [Parquet][C++] Remove redundant open calls in ParquetFileFormat::GetReaderAsync Nov 8, 2023
@mapleFU mapleFU merged commit e62ec62 into apache:main Nov 8, 2023
37 checks passed
@mapleFU mapleFU removed the awaiting committer review Awaiting committer review label Nov 8, 2023
@jorisvandenbossche
Copy link
Member

I labeled the issue as backport-candidate, though, in case we do another bug fix release

@mapleFU
Copy link
Member

mapleFU commented Nov 8, 2023

@jorisvandenbossche Maybe this should also related to #38466 and #38437 ? I'll drive them to be merged this week

Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e62ec62.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Nov 9, 2023
…tFileFormat::GetReaderAsync` (apache#38621)

### Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432.

### What changes are included in this PR?
Remove the extra method calls.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38591

Authored-by: Eero Lihavainen <eero.lihavainen@nitor.com>
Signed-off-by: mwish <maplewish117@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…tFileFormat::GetReaderAsync` (apache#38621)

### Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432.

### What changes are included in this PR?
Remove the extra method calls.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38591

Authored-by: Eero Lihavainen <eero.lihavainen@nitor.com>
Signed-off-by: mwish <maplewish117@gmail.com>
raulcd pushed a commit that referenced this pull request Nov 28, 2023
…ormat::GetReaderAsync` (#38621)

### Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from 0793432.

### What changes are included in this PR?
Remove the extra method calls.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #38591

Authored-by: Eero Lihavainen <eero.lihavainen@nitor.com>
Signed-off-by: mwish <maplewish117@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…tFileFormat::GetReaderAsync` (apache#38621)

### Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432.

### What changes are included in this PR?
Remove the extra method calls.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38591

Authored-by: Eero Lihavainen <eero.lihavainen@nitor.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Parquet][Python] Potential regression in Parquet parallel reading
4 participants