Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38589: [C++][Gandiva] Support registering external C functions #38632

Merged
merged 9 commits into from
Nov 17, 2023
Merged

GH-38589: [C++][Gandiva] Support registering external C functions #38632

merged 9 commits into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. Add initial support for extending gandiva stub functions.

    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0a86c38 View commit details
    Browse the repository at this point in the history

  2. Support registering gandiva functions that requires function holder a… 

    …s parameter.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2eb0237 View commit details
    Browse the repository at this point in the history

  3. Verify the external gandiva function that needs context to alloc memo… 

    …ry can work.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    23ae3b5 View commit details
    Browse the repository at this point in the history

  4. Rename public API to use c interface function to make this term consi… 

    …stent.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3871aac View commit details
    Browse the repository at this point in the history

  5. Add global mapping for external c interface functions and more tests … 

    …for LLVM generator using external C interface functions.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    93d8ac0 View commit details
    Browse the repository at this point in the history

  6. Export gandiva context related function calls so that they can be use… 

    …d with correct visibility on Windows.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    217e916 View commit details
    Browse the repository at this point in the history

  7. Rename C interface function to C function for simplicity.

    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    427556d View commit details
    Browse the repository at this point in the history

  8. Refactor the code to use the IRtype API in engine class, and calculat… 

    …e the correct number of arguments up front.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e9e248b View commit details
    Browse the repository at this point in the history

  9. Change several functions in external_c_functions from static function… 

    …s into anonymous namespace.
    @niyue
    niyue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ec24d23 View commit details
    Browse the repository at this point in the history