Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4734: [Go] Add option to write a header for CSV writer #3866

Closed
wants to merge 7 commits into from

Conversation

anson627
Copy link
Contributor

@anson627 anson627 changed the title Arrow 4734: Add option to write a header for CSV writer Arrow 4734: [Go] Add option to write a header for CSV writer Mar 11, 2019
@anson627 anson627 changed the title Arrow 4734: [Go] Add option to write a header for CSV writer ARROW-4734: [Go] Add option to write a header for CSV writer Mar 11, 2019
@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #3866 into master will decrease coverage by 0.2%.
The diff coverage is 75.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3866      +/-   ##
==========================================
- Coverage   87.78%   87.58%   -0.21%     
==========================================
  Files         727      653      -74     
  Lines       87892    84092    -3800     
  Branches     1252        0    -1252     
==========================================
- Hits        77158    73653    -3505     
+ Misses      10616    10325     -291     
+ Partials      118      114       -4
Impacted Files Coverage Δ
go/arrow/csv/writer.go 91.56% <71.42%> (-4.09%) ⬇️
go/arrow/csv/reader.go 80.19% <77.77%> (-0.24%) ⬇️
go/arrow/csv/common.go 75% <77.77%> (+0.53%) ⬆️
cpp/src/arrow/compute/kernel.h 62.63% <0%> (-26.05%) ⬇️
cpp/src/arrow/visitor.h 50% <0%> (-16.67%) ⬇️
cpp/src/arrow/util/decimal.h 85.71% <0%> (-14.29%) ⬇️
cpp/src/arrow/compute/logical_type.cc 52.68% <0%> (-9.65%) ⬇️
cpp/src/arrow/compute/expression.cc 40.1% <0%> (-7.23%) ⬇️
cpp/src/arrow/visitor_inline.h 88.5% <0%> (-6.44%) ⬇️
cpp/src/gandiva/tree_expr_builder.cc 51.3% <0%> (-6.43%) ⬇️
... and 333 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d62ca...af73b2e. Read the comment docs.

go/arrow/csv/writer.go Outdated Show resolved Hide resolved
@anson627
Copy link
Contributor Author

@sbinet I update the PR as what we discussed, can you help to take a look?

go/arrow/csv/reader.go Outdated Show resolved Hide resolved
go/arrow/csv/reader.go Outdated Show resolved Hide resolved
go/arrow/csv/reader.go Outdated Show resolved Hide resolved
go/arrow/csv/reader.go Outdated Show resolved Hide resolved
go/arrow/csv/writer.go Outdated Show resolved Hide resolved
go/arrow/csv/writer.go Outdated Show resolved Hide resolved
go/arrow/csv/writer.go Outdated Show resolved Hide resolved
go/arrow/schema.go Outdated Show resolved Hide resolved
@anson627
Copy link
Contributor Author

@sbinet ping

go/arrow/csv/reader.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nit-picks and then LGTM.

go/arrow/csv/reader.go Outdated Show resolved Hide resolved
go/arrow/Gopkg.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants