GH-38751: [C++][Go][Parquet] Add tests for reading Float16 files in parquet-testing #38753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: Go
Component: C++
awaiting review
github-actions
bot
added
awaiting committer review
mapleFU
approved these changes
Nov 17, 2023
zeroshade
approved these changes
Nov 17, 2023
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 26cf0e0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…s in parquet-testing (apache#38753) ### Rationale for this change Validates compatibility between implementations when reading `Float16` columns. ### What changes are included in this PR? - Bumps `parquet-testing` commit to latest to use the recently-added files - Adds reader tests for C++ and Go in the same vein as apache/arrow-rs#5003 ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38751 Authored-by: benibus <bpharks@gmx.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Validates compatibility between implementations when reading
Float16columns.What changes are included in this PR?
parquet-testingcommit to latest to use the recently-added filesAre these changes tested?
Yes
Are there any user-facing changes?
No