Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38902: [R] Handle failing library detection with pkg-config #38970

Merged
merged 13 commits into from
Dec 1, 2023
Merged

GH-38902: [R] Handle failing library detection with pkg-config #38970

merged 13 commits into from
Dec 1, 2023

Commits on Nov 30, 2023

  1. add workaround for failed pc detecton 

    pass proper libdir
    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ba1337b View commit details
    Browse the repository at this point in the history

  2. re-run add_feature_flags

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d90d7ce View commit details
    Browse the repository at this point in the history

  3. generalize retry for all pc fails

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c2c2367 View commit details
    Browse the repository at this point in the history

  4. don't silence pkg-config errors

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e65500a View commit details
    Browse the repository at this point in the history

  5. add missing else

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ccbe826 View commit details
    Browse the repository at this point in the history

  6. use portable check

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7090d7c View commit details
    Browse the repository at this point in the history

  7. make empty check more readable 

    Co-authored-by: Jonathan Keane <jkeane@gmail.com>
    @assignUser @jonkeane
    assignUser and jonkeane committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2306de7 View commit details
    Browse the repository at this point in the history

  8. dedpulicate -l flags and localize cloud flags

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8a61356 View commit details
    Browse the repository at this point in the history

  9. append ssl flags

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    057ac68 View commit details
    Browse the repository at this point in the history

  10. add pkg-config debug messages

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1d28b4e View commit details
    Browse the repository at this point in the history

  11. rephrase nixlib test compilation messages 

    update tests
    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    fdc87d3 View commit details
    Browse the repository at this point in the history

  12. rephrase latest nightly message

    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    29b4adb View commit details
    Browse the repository at this point in the history

  13. Revert "rephrase nixlib test compilation messages" 

    This reverts commit a7eb7d5.
    @assignUser
    assignUser committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    fb676f8 View commit details
    Browse the repository at this point in the history