GH-38316: [C#] Implement interval types #39043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix concatenation of Structs to work correctly.
github-actions
bot
added
Component: C#
Component: Documentation
awaiting review
CurtHagenlocher
requested review from
assignUser,
kou,
raulcd and
westonpace
as code owners
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 91f7330. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
### What changes are included in this PR? Changes required to support the three interval types in the C# implementation. ### Are these changes tested? Yes. ### Are there any user-facing changes? Adds new classes for interval support. * Closes: apache#38316 * Closes: apache#29431 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Platob <nfillot.pro@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### What changes are included in this PR? Changes required to support the three interval types in the C# implementation. ### Are these changes tested? Yes. ### Are there any user-facing changes? Adds new classes for interval support. * Closes: apache#38316 * Closes: apache#29431 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Platob <nfillot.pro@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? Changes required to support the three interval types in the C# implementation. ### Are these changes tested? Yes. ### Are there any user-facing changes? Adds new classes for interval support. * Closes: apache#38316 * Closes: apache#29431 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Platob <nfillot.pro@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Changes required to support the three interval types in the C# implementation.
Are these changes tested?
Yes.
Are there any user-facing changes?
Adds new classes for interval support.