Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38479: [C++] Avoid passing null pointer to LZ4 frame decompressor #39125

Merged
merged 1 commit into from
Dec 8, 2023
Merged

GH-38479: [C++] Avoid passing null pointer to LZ4 frame decompressor #39125

merged 1 commit into from
Dec 8, 2023

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Dec 7, 2023 •
edited by github-actions bot

Rationale for this change

Avoid undefined behavior in LZ4 when adding an offset to a null pointer.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

⚠️ GitHub issue #38479 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Dec 7, 2023

@github-actions crossbow submit sanitize

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Revision: a4ca020

Submitted crossbow builds: ursacomputing/crossbow @ actions-096f0cf193

Task Status
test-fedora-r-clang-sanitizer Azure
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-r-sanitizer Azure

@pitrou pitrou requested a review from felipecrv December 7, 2023 15:28
@pitrou
Copy link
Member Author

pitrou commented Dec 7, 2023

@kou There seem to be recurring C/GLib CI failures in various PRs:
https://github.com/apache/arrow/actions/runs/7130261904/job/19416226994?pr=39125#step:14:88

@pitrou
Copy link
Member Author

pitrou commented Dec 7, 2023

@paleolimbot Seems like the R sanitizer build succeeded.

@pitrou pitrou marked this pull request as ready for review December 7, 2023 17:19
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 7, 2023
@kou
Copy link
Member

kou commented Dec 7, 2023

@kou There seem to be recurring C/GLib CI failures in various PRs: https://github.com/apache/arrow/actions/runs/7130261904/job/19416226994?pr=39125#step:14:88

I've opened a new issue for it: #39130

kou
kou approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@felipecrv Do you want to merge this as a new committer?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Dec 7, 2023
paleolimbot
paleolimbot approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@felipecrv felipecrv merged commit b75755a into apache:main Dec 8, 2023
35 of 37 checks passed
@pitrou pitrou deleted the gh-38479-lz-ub branch December 8, 2023 19:43
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b75755a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

@felipecrv felipecrv added this to the 15.0.0 milestone Dec 11, 2023
mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Dec 13, 2023
@pitrou @mapleFU
apacheGH-38479: [C++] Avoid passing null pointer to LZ4 frame decompr…
1a94c3f 
…essor (apache#39125)

### Rationale for this change

Avoid undefined behavior in LZ4 when adding an offset to a null pointer.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38479
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
@pitrou @clayburn
apacheGH-38479: [C++] Avoid passing null pointer to LZ4 frame decompr…
9a1a35f 
…essor (apache#39125)

### Rationale for this change

Avoid undefined behavior in LZ4 when adding an offset to a null pointer.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38479
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@pitrou @dgreiss
apacheGH-38479: [C++] Avoid passing null pointer to LZ4 frame decompr…
93704bd 
…essor (apache#39125)

### Rationale for this change

Avoid undefined behavior in LZ4 when adding an offset to a null pointer.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@felipecrv felipecrv felipecrv approved these changes

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
15.0.0
Development

Successfully merging this pull request may close these issues.

[R][C++] Undefined behaviour (clang sanitizer) in decompression
4 participants
@pitrou @kou @felipecrv @paleolimbot