ARROW-4933: [R] Autodetect Parquet support using pkg-config #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 17, 2019
| @@ -32,13 +32,26 @@ PKG_RPM_NAME="arrow" | |||
| PKG_CSW_NAME="arrow" | |||
| PKG_BREW_NAME="apache-arrow" | |||
| PKG_TEST_HEADER="<arrow/api.h>" | |||
| PKG_LIBS="-larrow -lparquet" | |||
| PKG_LIBS="" | |||
|
|
|||
| # Use pkg-config if available | |||
| pkg-config --version >/dev/null 2>&1 | |||
| if [ $? -eq 0 ]; then | |||
| PKGCONFIG_CFLAGS=`pkg-config --cflags --silence-errors ${PKG_CONFIG_NAME}` | |||
| PKGCONFIG_LIBS=`pkg-config --libs ${PKG_CONFIG_NAME}` | |||
There was a problem hiding this comment.
Needless codes are remained.
I've created a pull request: #3951
There was a problem hiding this comment.
It's not needless code, it's a default on systems where pkg-config is unavailable. Also this PR has broken the build on MacOS. Did anyone actually test this?
There was a problem hiding this comment.
Could you open a new JIRA issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos go to @kou for this.