Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39588: [CI][Go] Add CGO_ENABLED=1 to cdata_integration build to fix macOS build with conda #39589

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 12, 2024

Rationale for this change

CI job has been failing since we added integration tests.

What changes are included in this PR?

Add CGO_ENABLED=1 to go build cdata_integration on the verification script.

Are these changes tested?

Yes via archery.

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Jan 12, 2024

@github-actions crossbow submit verify-rc-source-integration-macos-conda-amd64

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 12, 2024
Copy link

Revision: 502f666

Submitted crossbow builds: ursacomputing/crossbow @ actions-3e60a461c3

Task Status
verify-rc-source-integration-macos-conda-amd64 GitHub Actions

@raulcd raulcd changed the title WIP: DO NOT MERGE: Testing a crossbow job GH-39588: [CI][Go] Add CGO_ENABLED=1 to cdata_integration build to fix macOS build with conda Jan 12, 2024
Copy link

⚠️ GitHub issue #39588 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 12, 2024

@github-actions crossbow submit verify-rc-source-integration-*

@raulcd raulcd marked this pull request as ready for review January 12, 2024 22:08
Copy link

Revision: 502f666

Submitted crossbow builds: ursacomputing/crossbow @ actions-a83fa6958a

Task Status
verify-rc-source-integration-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 13, 2024
@raulcd raulcd merged commit 7e703aa into apache:main Jan 14, 2024
8 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Jan 14, 2024
raulcd added a commit that referenced this pull request Jan 14, 2024
…x macOS build with conda (#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: #39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7e703aa.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

idailylife pushed a commit to idailylife/arrow that referenced this pull request Jan 18, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Go] The verify-rc-source-integration-macos-conda-amd64 job fails building cdata_integration for go
2 participants