GH-39860: [C++] Expression ExecuteScalarExpression execute empty args function with a wrong result #39908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
ZhangHuiGui
changed the title
|
|
bkietz
requested changes
Feb 2, 2024
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting review
mapleFU
reviewed
Feb 3, 2024
| exec_context->func_registry()->GetFunction("random")); | ||
| ASSERT_OK_AND_ASSIGN(Datum expected, | ||
| function->Execute(input, &random_options, exec_context)); | ||
| AssertDatumsEqual(actual, expected, /*verbose=*/true); |
There was a problem hiding this comment.
Should we check the output length == 10 explicit?
github-actions
bot
added
awaiting committer review
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit fd69d30. There were 2 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…y args function with a wrong result (apache#39908) ### Rationale for this change Try to fix apache#39860. ### What changes are included in this PR? Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions has no arguments, like (random, hash_count ...). ### Are these changes tested? Yes ### Are there any user-facing changes? No. * Closes: apache#39860 Lead-authored-by: hugo.zhang <hugo.zhang@openpie.com> Co-authored-by: 张回归 <zhanghuigui@zhanghuiguideMacBook-Pro-1681.local> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
… function with a wrong result (#39908) ### Rationale for this change Try to fix #39860. ### What changes are included in this PR? Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions has no arguments, like (random, hash_count ...). ### Are these changes tested? Yes ### Are there any user-facing changes? No. * Closes: #39860 Lead-authored-by: hugo.zhang <hugo.zhang@openpie.com> Co-authored-by: 张回归 <zhanghuigui@zhanghuiguideMacBook-Pro-1681.local> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…y args function with a wrong result (apache#39908) ### Rationale for this change Try to fix apache#39860. ### What changes are included in this PR? Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions has no arguments, like (random, hash_count ...). ### Are these changes tested? Yes ### Are there any user-facing changes? No. * Closes: apache#39860 Lead-authored-by: hugo.zhang <hugo.zhang@openpie.com> Co-authored-by: 张回归 <zhanghuigui@zhanghuiguideMacBook-Pro-1681.local> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
mdianjun
pushed a commit
to marsno1/arrow
that referenced
this pull request
Mar 1, 2024
…y args function with a wrong result (apache#39908) Try to fix apache#39860. Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions has no arguments, like (random, hash_count ...). Yes No. * Closes: apache#39860 Lead-authored-by: hugo.zhang <hugo.zhang@openpie.com> Co-authored-by: 张回归 <zhanghuigui@zhanghuiguideMacBook-Pro-1681.local> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…y args function with a wrong result (apache#39908) ### Rationale for this change Try to fix apache#39860. ### What changes are included in this PR? Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions has no arguments, like (random, hash_count ...). ### Are these changes tested? Yes ### Are there any user-facing changes? No. * Closes: apache#39860 Lead-authored-by: hugo.zhang <hugo.zhang@openpie.com> Co-authored-by: 张回归 <zhanghuigui@zhanghuiguideMacBook-Pro-1681.local> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Try to fix #39860.
What changes are included in this PR?
Deal with the call->arguments.size() == 0's condition in ExecuteScalarExpression when we call some functions
has no arguments, like (random, hash_count ...).
Are these changes tested?
Yes
Are there any user-facing changes?
No.