Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39987: [R] Make it possible to use a rtools libarrow on windows #39986

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Feb 7, 2024

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

Copy link

github-actions bot commented Feb 7, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

Copy link

github-actions bot commented Feb 7, 2024

Revision: f405c66

Submitted crossbow builds: ursacomputing/crossbow @ actions-e8f1c270de

Task Status
r-binary-packages GitHub Actions

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing it, but where do we download from rwlinlib (specifically, https://github.com/rwinlib/arrow/archive/refs/tags/v13.0.0.zip right?)

r/configure.win Outdated Show resolved Hide resolved
# pkg-config --libs libcurl
GCS_LIBS="-lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto -lcrypt32 -lwldap32 \
-lz -lws2_32 -lnghttp2 -ldbghelp"
# Test if pkg-config is available to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Rtools always have pkg-config? If so, we can probably simplify things here since there's only one way to build on Windows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtools43 does, not sure about older versions

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 7, 2024
@assignUser assignUser changed the title [WIP] [R] Make it possible to use a rtools libarrow on windows GH-39987: [R] Make it possible to use a rtools libarrow on windows Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

⚠️ GitHub issue #39987 has been automatically assigned in GitHub to PR creator.

Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
@assignUser
Copy link
Member Author

assignUser commented Feb 7, 2024

but where do we download from rwlinlib

We don't, since we added checksum verification in #37941 we use the artifactory for windows too.

@nealrichardson
Copy link
Member

but where do we download from rwlinlib

We don't, since we added checksum verification in #37941 we use the artifactory for windows too (as we generate checksums during the release).

I think for CRAN submission we should use rwinlib.

@assignUser assignUser merged commit e1241e7 into apache:main Feb 8, 2024
10 checks passed
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Feb 8, 2024
assignUser added a commit that referenced this pull request Feb 8, 2024
…39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: #39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e1241e7.

There was 1 benchmark result with an error:

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ows (apache#39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: apache#39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…ows (apache#39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: apache#39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit that referenced this pull request Mar 1, 2024
…39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: #39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit that referenced this pull request Mar 6, 2024
…39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: #39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit that referenced this pull request Mar 8, 2024
…39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: #39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…ows (apache#39986)

This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will  be part of a future rtools version.

These changes can't be tested, there are no user facing changes for now.

* Closes: apache#39987

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] Make it possible to use an existing (rtools) install of libarrow on Windows
2 participants