MINOR: [Docs] Use ' and remove trailing spaces in basic_arrow.rst #39989
Conversation
amoeba
changed the title
kou
changed the title
|
@github-actions crossbow submit preview-docs |
|
Can we introduce linter/formatter for |
|
Revision: d15468a Submitted crossbow builds: ursacomputing/crossbow @ actions-5240b8fe97
|
|
Not a bad idea. The original issue I found (ambiguous unicode chars) should hopefully be very rare as characters like that only get introduced when contributors use editors not meant for source code. A check in CI for the second issue (non-normalized whitespace) would be nice. I can file an issue to look into it. |
|
I filed #39990 and will have a look. |
|
Hey @kou, I think sphinx-lint might work here, see my comment. I didn't find anything that can catch ambiguous Unicode characters so I still think this PR should be merged. I'll work on another PR for #39990. |
|
Thanks! I want to ensure whether this change doesn't introduce a syntax error before I merge this. But |
Works for me.
Of course, I'll keep an eye on that. |
|
I've merged #39993. Could you rebase on main? |
github-actions
bot
added
awaiting merge
amoeba
force-pushed
the
fix-basic-arrow-docs
branch
from
d15468a
to
3c7aa44
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 3c7aa44 Submitted crossbow builds: ursacomputing/crossbow @ actions-d426402f0d
|
|
Hi @kou, I've rebased and started another docs build. I tested the output locally too and it looks fine. This should be ready for another look. |
kou
force-pushed
the
fix-basic-arrow-docs
branch
from
3c7aa44
to
571201c
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 571201c Submitted crossbow builds: ursacomputing/crossbow @ actions-c509de5fda
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d989191. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Thanks @kou. |
…ache#39989) ### Rationale for this change basic_arrow.rst had two minor issues: - It used `’` (U+2019) instead of `'` - While editing, I found it wasn't whitespace normalized ### What changes are included in this PR? - `’` replaced with `'` - Whitespace has been normalized ### Are these changes tested? No ### Are there any user-facing changes? Just docs. Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#39989) ### Rationale for this change basic_arrow.rst had two minor issues: - It used `’` (U+2019) instead of `'` - While editing, I found it wasn't whitespace normalized ### What changes are included in this PR? - `’` replaced with `'` - Whitespace has been normalized ### Are these changes tested? No ### Are there any user-facing changes? Just docs. Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#39989) ### Rationale for this change basic_arrow.rst had two minor issues: - It used `’` (U+2019) instead of `'` - While editing, I found it wasn't whitespace normalized ### What changes are included in this PR? - `’` replaced with `'` - Whitespace has been normalized ### Are these changes tested? No ### Are there any user-facing changes? Just docs. Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
basic_arrow.rst had two minor issues:
’(U+2019) instead of'What changes are included in this PR?
’replaced with'Are these changes tested?
No
Are there any user-facing changes?
Just docs.