Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.29 to 10.13.0 in /java #40046

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 12, 2024

Bumps com.puppycrawl.tools:checkstyle from 8.29 to 10.13.0.

Release notes

Sourced from com.puppycrawl.tools:checkstyle's releases.

checkstyle-10.13.0

Checkstyle 10.13.0 - https://checkstyle.org/releasenotes.html#Release_10.13.0

New:

#14289 - IllegalTokenText support for STRING_TEMPLATE_CONTENT #13830 - Support Java 21 string template syntax

Bug fixes:

#12238 - "Unable to persist cache file" if target directory is a symlink

checkstyle-10.12.7

Checkstyle 10.12.7 - https://checkstyle.org/releasenotes.html#Release_10.12.7

Bug fixes:

#14068 - False positive in MissingSwitchDefault for switch statement where null label is present #14028 - HiddenField false positive on inner records #3132 - Indentation: split line new array not checked

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 8.29 to 10.13.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-8.29...checkstyle-10.13.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from lidavidm as a code owner February 12, 2024 16:30
@dependabot dependabot bot added dependencies Dependabot-only java Dependabot-only labels Feb 12, 2024
@kou
Copy link
Member

kou commented Feb 13, 2024

it seems that we can't use this version with old Java:

https://github.com/apache/arrow/actions/runs/7874853054/job/21485424364?pr=40046#step:6:273

java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/AuditListener has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@vibhatha
Copy link
Collaborator

@kou we recently made a customized PR for upgrading to 8.29. Should we upgrade again?

@lidavidm
Copy link
Member

Er, Vibhatha - when we discussed the last PR it was to upgrade to the last possible version we could, so anything more isn't doable until we drop Java 8. Make sure it's on the list of things to upgrade after Java 8 is dropped and we can close this for now.

@lidavidm
Copy link
Member

Added here #38051

@lidavidm lidavidm closed this Feb 13, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 13, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/java/com.puppycrawl.tools-checkstyle-10.13.0 branch February 13, 2024 01:00
@vibhatha
Copy link
Collaborator

@lidavidm thanks, I will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting review Component: Java dependencies Dependabot-only java Dependabot-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants