Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 #40120

Conversation

Tom-Newton
Copy link
Contributor

@Tom-Newton Tom-Newton commented Feb 18, 2024

Rationale for this change

cffi 1.16.0 conda release for python 3.9 was modified 12 days ago and it seems to have broken grpcio==1.59.0.

What changes are included in this PR?

Restrict cffi to < 1.16.0. Perhaps someone should investigate further and get the build working again with the 1.16.0 release but I think at least in the short term restricting the version like this is the best option.

Are these changes tested?

No new functionality to test. Should fix existing CI failures.

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #40112 has been automatically assigned in GitHub to PR creator.

@@ -17,7 +17,7 @@

# don't add pandas here, because it is not a mandatory test dependency
boto3 # not a direct dependency of s3fs, but needed for our s3fs fixture
cffi
cffi<1.16.0 # cffi 1.16.0 with Python 3.9 has an incompatibility with grpcio (required for GCS testbench)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Can we restrict this pin only for Python 3.9? It seems that we can do it with requirements.txt but I don't know whether we can do it with conda...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's possible with conda. The only docs I could find about the version specification syntax was this https://docs.conda.io/projects/conda/en/4.6.0/_downloads/52a95608c49671267e40c689e0bc00ca/conda-cheatsheet.pdf

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 19, 2024
@xhochy
Copy link
Member

xhochy commented Feb 19, 2024

We can fix that on the conda-forge side so that you don't have to restrict anything here. Do you have an upstream bug report I could reference to argue for retroactively adding the pin?

@Tom-Newton
Copy link
Contributor Author

Better fix was merged #40131

@Tom-Newton Tom-Newton closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Packaging] Python 3.9 conda builds fail to install GCS testbench
3 participants