Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1477: [C++] sync thrift to final crypto spec #4022

Closed

Conversation

ggershinsky
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #4022 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4022      +/-   ##
==========================================
+ Coverage   87.83%   87.83%   +<.01%     
==========================================
  Files         734      734              
  Lines       90433    90433              
  Branches     1252     1252              
==========================================
+ Hits        79429    79432       +3     
+ Misses      10883    10880       -3     
  Partials      121      121
Impacted Files Coverage Δ
cpp/src/arrow/io/readahead.cc 95.95% <0%> (-1.02%) ⬇️
cpp/src/arrow/util/thread-pool-test.cc 97.66% <0%> (-0.94%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 71.69% <0%> (+0.94%) ⬆️
js/src/ipc/metadata/json.ts 96.73% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e9ec3...0ce831e. Read the comment docs.

@wesm
Copy link
Member

wesm commented Mar 25, 2019

Can you create a JIRA issue for this?

@ggershinsky ggershinsky changed the title sync thrift to final crypto spec PARQUET-1477: [C++] sync thrift to final crypto spec Mar 25, 2019
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in a0b4a8c Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants