-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40644: [Python] Allow passing a mapping of column names to rename_columns
#40645
Conversation
|
c7bb72e
to
01ad9b5
Compare
01ad9b5
to
11ad87d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good feature, thank you!
@AlenkaF is there anything else I need to do here? I'm still a little unclear what the review process is. |
There is nothing needed from you at the moment but I normally like another pair of 👀 before merging. The 16.0.0 release is in process at the moment so another review might not be done very fast but will work on getting this merged soon. |
@judahrand could you address the last comment? Then I am happy to merge this PR =) |
Test failure is: #41149 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for being responsive and patient!
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7347eb2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…rename_columns` (apache#40645) ### Rationale for this change See apache#40644 ### What changes are included in this PR? ### Are these changes tested? Yes. Tests have been added. ### Are there any user-facing changes? * GitHub Issue: apache#40644 Authored-by: Judah Rand <17158624+judahrand@users.noreply.github.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
…rename_columns` (apache#40645) ### Rationale for this change See apache#40644 ### What changes are included in this PR? ### Are these changes tested? Yes. Tests have been added. ### Are there any user-facing changes? * GitHub Issue: apache#40644 Authored-by: Judah Rand <17158624+judahrand@users.noreply.github.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Rationale for this change
See #40644
What changes are included in this PR?
Are these changes tested?
Yes.
Tests have been added.
Are there any user-facing changes?
rename_columns
to take a mapping #40644