Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40644: [Python] Allow passing a mapping of column names to rename_columns #40645

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Mar 18, 2024

Rationale for this change

See #40644

What changes are included in this PR?

Are these changes tested?

Yes.

Tests have been added.

Are there any user-facing changes?

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 18, 2024
Copy link

⚠️ GitHub issue #40644 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good feature, thank you!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 19, 2024
@judahrand
Copy link
Contributor Author

@AlenkaF is there anything else I need to do here? I'm still a little unclear what the review process is.

@AlenkaF
Copy link
Member

AlenkaF commented Apr 10, 2024

There is nothing needed from you at the moment but I normally like another pair of 👀 before merging. The 16.0.0 release is in process at the moment so another review might not be done very fast but will work on getting this merged soon.

@AlenkaF
Copy link
Member

AlenkaF commented Apr 15, 2024

@judahrand could you address the last comment? Then I am happy to merge this PR =)

@judahrand judahrand requested a review from AlenkaF April 15, 2024 09:47
@judahrand
Copy link
Contributor Author

@judahrand could you address the last comment? Then I am happy to merge this PR =)

Test failure is: #41149

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being responsive and patient!

@AlenkaF AlenkaF merged commit 7347eb2 into apache:main Apr 15, 2024
12 of 13 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Apr 15, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7347eb2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…rename_columns` (apache#40645)

### Rationale for this change

See apache#40644 

### What changes are included in this PR?

### Are these changes tested?

Yes.

Tests have been added.

### Are there any user-facing changes?

* GitHub Issue: apache#40644

Authored-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…rename_columns` (apache#40645)

### Rationale for this change

See apache#40644 

### What changes are included in this PR?

### Are these changes tested?

Yes.

Tests have been added.

### Are there any user-facing changes?

* GitHub Issue: apache#40644

Authored-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants