Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40814: [C++] Thirdparty: bump zstd to 1.5.6 #40837

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Mar 27, 2024

Rationale for this change

Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6

What changes are included in this PR?

Change default zstd to 1.5.6

Are these changes tested?

Already has test

Are there any user-facing changes?

no

@mapleFU mapleFU changed the title [C++] Thirdparty: bump zstd to 1.5.6 chrome edition GH-40814: [C++] Thirdparty: bump zstd to 1.5.6 chrome edition Mar 27, 2024
@github-actions github-actions bot added the awaiting review Awaiting review label Mar 27, 2024
Copy link

⚠️ GitHub issue #40814 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member Author

mapleFU commented Mar 27, 2024

Will trigger other tests and benchmarks after ci passed

@mapleFU
Copy link
Member Author

mapleFU commented Mar 27, 2024

@github-actions crossbow submit -g cpp -g wheel

Copy link

Revision: 3d70921

Submitted crossbow builds: ursacomputing/crossbow @ actions-d7ab385f63

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@mapleFU
Copy link
Member Author

mapleFU commented Mar 27, 2024

cc @pitrou @kou

@pitrou pitrou changed the title GH-40814: [C++] Thirdparty: bump zstd to 1.5.6 chrome edition GH-40814: [C++] Thirdparty: bump zstd to 1.5.6 Mar 27, 2024
@pitrou pitrou requested a review from kou March 27, 2024 15:04
@felipecrv
Copy link
Contributor

LGTM. I trust the CI tests to confirm there is no issue.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b270dcd into apache:main Mar 28, 2024
34 of 35 checks passed
@kou kou removed the awaiting review Awaiting review label Mar 28, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 28, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b270dcd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
### Rationale for this change

Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6

### What changes are included in this PR?

Change default zstd to 1.5.6

### Are these changes tested?

Already has test

### Are there any user-facing changes?

no

* GitHub Issue: apache#40814

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6

### What changes are included in this PR?

Change default zstd to 1.5.6

### Are these changes tested?

Already has test

### Are there any user-facing changes?

no

* GitHub Issue: apache#40814

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants