-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40814: [C++] Thirdparty: bump zstd to 1.5.6 #40837
Conversation
|
Will trigger other tests and benchmarks after ci passed |
@github-actions crossbow submit -g cpp -g wheel |
Revision: 3d70921 Submitted crossbow builds: ursacomputing/crossbow @ actions-d7ab385f63 |
LGTM. I trust the CI tests to confirm there is no issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b270dcd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6 ### What changes are included in this PR? Change default zstd to 1.5.6 ### Are these changes tested? Already has test ### Are there any user-facing changes? no * GitHub Issue: apache#40814 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6 ### What changes are included in this PR? Change default zstd to 1.5.6 ### Are these changes tested? Already has test ### Are there any user-facing changes? no * GitHub Issue: apache#40814 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Zstd releases 1.5.6 here: https://github.com/facebook/zstd/releases/tag/v1.5.6
What changes are included in this PR?
Change default zstd to 1.5.6
Are these changes tested?
Already has test
Are there any user-facing changes?
no