Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5119: [Go] fix Boolean stringer implementation #4112

Closed
wants to merge 1 commit into from

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Apr 4, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #4112 into master will decrease coverage by 18.65%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4112       +/-   ##
===========================================
- Coverage   87.82%   69.16%   -18.66%     
===========================================
  Files         739       61      -678     
  Lines       90965     4206    -86759     
  Branches     1252        0     -1252     
===========================================
- Hits        79886     2909    -76977     
+ Misses      10958     1188     -9770     
+ Partials      121      109       -12
Impacted Files Coverage Δ
go/arrow/array/boolean.go 48.27% <0%> (ø) ⬆️
go/arrow/math/float64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/int64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
... and 682 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a93316...994c4ae. Read the comment docs.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 4, 2019

@stuartcarnie @alexandreyc PTAL

@alexandreyc
Copy link
Contributor

Good catch!

LGTM

@wesm
Copy link
Member

wesm commented Apr 4, 2019

This is not tested I guess?

@sbinet
Copy link
Contributor Author

sbinet commented Apr 4, 2019

this was, but the array was - by shear luck - of the correct size.
I'll modify an example/test to exercize it.

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sbinet
Copy link
Contributor Author

sbinet commented Apr 5, 2019

@wesm: added the test as part of #4114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants