ARROW-4708: [C++] refactoring JSON parser to prepare for multithreaded impl #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't use in-situ parsing - don't require null termination of parsed buffers - resize parser's scalar storage when it might overflow - rewrite chunker to use Buffer instead of string_view to represent memory ranges - iwyu + lint cleanup - add test for parsing JSON with a partial schema - add test for inferring timestamp type in an unexpected field of strings
|
@pitrou I have removed the converter/reader changes, this PR only affects the chunker, parser, and utilities. |
Codecov Report
@@ Coverage Diff @@
## master #4148 +/- ##
==========================================
+ Coverage 87.85% 89.16% +1.31%
==========================================
Files 748 617 -131
Lines 91842 81857 -9985
Branches 1251 0 -1251
==========================================
- Hits 80687 72988 -7699
+ Misses 11036 8869 -2167
+ Partials 119 0 -119
Continue to review full report at Codecov.
|
pitrou
reviewed
Apr 15, 2019
|
@pitrou how's this? |
pitrou
requested changes
Apr 16, 2019
cpp/src/arrow/json/rapidjson-defs.h
Outdated
| } | ||
|
|
||
| // enable SIMD whitespace skipping, if available | ||
| #if defined(__SSE4_2__) |
There was a problem hiding this comment.
Should use ARROW_HAVE_SSE4_2 from sse-util.h instead.
|
@pitrou done |
pitrou
approved these changes
Apr 17, 2019
|
Thank you @bkietz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to represent memory ranges
field of strings