ARROW-5129: [Rust] Column writer bug: check dictionary encoder when adding a new data page #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sunchao. Can you review? Thanks! |
|
hi @sadikovi, may you please format the title of the PR as ARROW-5129: [Rust] ..., thanks :) |
sunchao
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when we would encode all data into a single data page, unless we fall back to secondary encoder. Added test to verify the correctness of the patch.
Test is a bit awkward and clunky, but that is the only way I could come up to test the patch, since I need to check the written pages (I could not get "adding buffer to TestPageWriter" to work because of the box + lifetime issues).