Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41566: [CI][Packaging] macOS wheel for Catalina fails to build on macOS arm64 #41567

Merged
merged 1 commit into from
May 7, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented May 7, 2024

Rationale for this change

Wheels for macOS catalina are failing

What changes are included in this PR?

Use macos-13 instead of (latest) ARM

Are these changes tested?

Yes, via archery

Are there any user-facing changes?

No

Copy link

github-actions bot commented May 7, 2024

⚠️ GitHub issue #41566 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented May 7, 2024

@github-actions crossbow submit wheel-macos-catalina-*

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Revision: 4316e90

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c1868602e

Task Status
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 7, 2024
@raulcd raulcd marked this pull request as ready for review May 7, 2024 12:46
@raulcd raulcd requested review from assignUser and kou as code owners May 7, 2024 12:46
@raulcd
Copy link
Member Author

raulcd commented May 7, 2024

@kou this seems to have started failing for macOS arm64. I am going to merge the change to unblock 16.1.0 and if you think is necessary we can open an issue to update to macos-latest in the future.

@raulcd raulcd merged commit c79b6a5 into apache:main May 7, 2024
9 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label May 7, 2024
@raulcd raulcd deleted the GH-41566 branch May 7, 2024 12:54
raulcd added a commit that referenced this pull request May 7, 2024
…macOS arm64 (#41567)

### Rationale for this change

Wheels for macOS catalina are failing

### What changes are included in this PR?

Use macos-13 instead of (latest) ARM

### Are these changes tested?

Yes, via archery

### Are there any user-facing changes?

No
* GitHub Issue: #41566

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c79b6a5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@kou
Copy link
Member

kou commented May 7, 2024

Thanks!
We don't need to open an issue for using macos-latest for this task. If we can't use GitHub hosted macOS runner, we'll drop support for intel macOS wheels.

@jorisvandenbossche
Copy link
Member

If we can't use GitHub hosted macOS runner, we'll drop support for intel macOS wheels.

FWIW we will have to support intel mac wheels for quite some time. So in case github actions would drop the older (intel) mac runners (but I assume that will also still take some years, given they only deprecated macos-11 no, and there are still macos-12 and 13), we just have to figure out how to actually fix building it on am arm64 machine, because it should support cross-compiling

@kou
Copy link
Member

kou commented May 8, 2024

I see. Could you open a new issue for it?

@jorisvandenbossche
Copy link
Member

As long as github provides an intel-based macos runner (which I assume they will still do for some years), I think it is actually better to use those and to not cross-compile, so for now I don't think there is anything to do (this PR was a good fix)

@kou
Copy link
Member

kou commented May 8, 2024

OK!

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ld on macOS arm64 (apache#41567)

### Rationale for this change

Wheels for macOS catalina are failing

### What changes are included in this PR?

Use macos-13 instead of (latest) ARM

### Are these changes tested?

Yes, via archery

### Are there any user-facing changes?

No
* GitHub Issue: apache#41566

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants