Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4717 [C#] Consider exposing ValueTask instead of Task #4194

Closed
wants to merge 3 commits into from
Closed

ARROW-4717 [C#] Consider exposing ValueTask instead of Task #4194

wants to merge 3 commits into from

Conversation

eerhardt
Copy link
Contributor

Eliminating allocations in the C# Arrow library:

  1. Use ValueTask instead of Task in the public APIs.
  2. Eliminate allocations in ArrayData constructor by taking an array directly instead of calling ToArray() every time.
  3. Remove some other minor allocations that provide no benefit.
  4. Also, add a simple NullCount == 0 check to optimize the case where there are no nulls in the data, but the null bitmap is filled with 0s instead of being empty.

With this change the ArrowReaderWithMemory benchmark in the repo goes from:

Before

Method Allocated Memory/Op
ArrowReaderWithMemory 5.84 KB

After

Method Allocated Memory/Op
ArrowReaderWithMemory 4.48 KB

@stephentoub @pgovind @chutchinson

@eerhardt
Minor optimizations
d1d2687 
- Eliminate allocations in ArrayData constructor.
- Optimize for when NullCount == 0
- Remove unnecessary allocations.
@eerhardt
Convert all Task usages to ValueTask to save on allocations.
310bb2f
@eerhardt
PR feedback.
d2a00af 
Revert some ValueTask usages back to Task.
@eerhardt
Copy link
Contributor Author

@xhochy @wesm @kou - I believe all feedback has been addressed and this is ready to be merged.

wesm
wesm approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 3514a37 Apr 30, 2019
@eerhardt eerhardt deleted the ValueTask branch April 30, 2019 14:38
@asfimport asfimport mentioned this pull request Apr 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eerhardt @wesm @stephentoub