GH-42232: [C++] Use non-stale c-ares download URL #42250
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions crossbow submit test-r-offline-maximal |
|
Revision: bc09a4a Submitted crossbow builds: ursacomputing/crossbow @ actions-a6ca746f66
|
cpp/thirdparty/versions.txt
Outdated
| @@ -144,7 +146,7 @@ DEPENDENCIES=( | |||
| "ARROW_BOOST_URL boost-${ARROW_BOOST_BUILD_VERSION}.tar.gz https://apache.jfrog.io/artifactory/arrow/thirdparty/7.0.0/boost_${ARROW_BOOST_BUILD_VERSION//./_}.tar.gz" | |||
| "ARROW_BROTLI_URL brotli-${ARROW_BROTLI_BUILD_VERSION}.tar.gz https://github.com/google/brotli/archive/${ARROW_BROTLI_BUILD_VERSION}.tar.gz" | |||
| "ARROW_BZIP2_URL bzip2-${ARROW_BZIP2_BUILD_VERSION}.tar.gz https://sourceware.org/pub/bzip2/bzip2-${ARROW_BZIP2_BUILD_VERSION}.tar.gz" | |||
| "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz https://c-ares.haxx.se/download/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz" | |||
| "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz https://github.com/c-ares/c-ares/releases/download/cares-${ARROW_CARES_BUILD_VERSION_UNDERSCORES}/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz" | |||
There was a problem hiding this comment.
How about using ${...//PATTERN/REPLACED} bash feature instead of defining ..._UNDERSCORES like ARROW_BOOST_BUILD_VERSION did?
(This data is used by only download_dependencies.sh.)
| "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz https://github.com/c-ares/c-ares/releases/download/cares-${ARROW_CARES_BUILD_VERSION_UNDERSCORES}/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz" | |
| "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz https://github.com/c-ares/c-ares/releases/download/cares-${ARROW_CARES_BUILD_VERSION//./_}/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz" |
There was a problem hiding this comment.
Sure, can do. I didn't see the boost version up there
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit test-r-offline-maximal |
github-actions
bot
added
awaiting change review
|
Revision: e363e1f Submitted crossbow builds: ursacomputing/crossbow @ actions-495d6f0b18
|
|
Thanks! |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3fe4df3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The URL to download the c-ares dependency is stale. Note: we weren't seeing this bonk on most CI because we have the fallback of our own copy of these. But the R script that downloads all of our thirdparty deps always uses the official URL which is the one that had moved.
Resolves #42232
What changes are included in this PR?
Use the appropriate URL, muck with
.->_Are these changes tested?
The current CI should pass + the R maximal offline build should pass too
Are there any user-facing changes?
More reliable retrieval of all thirdparty dependencies