ARROW-4505: [C++] adding pretty print for dates, times, and timestamps #4268
Conversation
bkietz
force-pushed
the
4505-Nicer-PrettyPrint-for-date32
branch
from
88de6cb
to
b53c013
Compare
bkietz
force-pushed
the
4505-Nicer-PrettyPrint-for-date32
branch
from
b53c013
to
9086c9d
Compare
cpp/src/arrow/pretty_print.cc
Outdated
| Status WriteDataValues(const TimestampArray& array) { | ||
| const int64_t* data = array.raw_values(); | ||
| const auto type = static_cast<const TimestampType*>(array.type().get()); | ||
| const auto fmt = "%F %T" + type->timezone(); |
There was a problem hiding this comment.
The timezone is part of the type, it shouldn't be appended to the pretty-printed values IMHO.
cpp/src/arrow/pretty_print-test.cc
Outdated
| 1970-01-02 03:04:05.000678Z, | ||
| null | ||
| ])expected"; | ||
| CheckPrimitive<TimestampType, int64_t>(timestamp(TimeUnit::MICRO, "Z"), {0, 10}, |
There was a problem hiding this comment.
While "Z" is a valid suffix to ISO 8601 timestamps, the name of the timezone wouldn't be "Z", it would be something like "UTC".
Besides, if the timezone is named e.g. "Europe/Paris", you don't want to append that to the formatted timestamp.
There was a problem hiding this comment.
Indeed. Not for this PR, but it would then be nice to actually somehow show the type information in the repr of the array:
In [55]: pa.array([pd.Timestamp("2012-01-01", tz='Europe/Paris')])
Out[55]:
<pyarrow.lib.TimestampArray object at 0x7ffa5d5060e8>
[
1325376000000000
]
because currently you don't see the timezone, and also not the unit of the timestamp, without actually printing the array's type as well.
There was a problem hiding this comment.
@jorisvandenbossche That looks more like a Python-specific issue.
|
Thank you @bkietz. This can be merged when CI is green. |
<TimeUnit>since epoch)<TimeUnit>since midnight)<TimeUnit>since midnight)