GH-43058: [C#] Revert upgrade of Xunit from 2.8.0 to 2.8.1 #43074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Jun 28, 2024
|
@github-actions crossbow submit verify-rc-source-csharp-* |
|
Revision: 9ccaab0 Submitted crossbow builds: ursacomputing/crossbow @ actions-de71895c86
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8909163. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
adamreeve
added a commit
to adamreeve/arrow
that referenced
this pull request
Jul 1, 2024
…8.1 (apache#43074)" This reverts commit 8909163.
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Jul 9, 2024
…che#43074) ### Rationale for this change See apache#43058, this release broke compatibility with xunit.skippablefact and caused skipped tests to be treated as failures. ### What changes are included in this PR? This reverts commit ef3d467. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#43058 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #43058, this release broke compatibility with xunit.skippablefact and caused skipped tests to be treated as failures.
What changes are included in this PR?
This reverts commit ef3d467.
Are these changes tested?
Yes
Are there any user-facing changes?
No