Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41696: [Python][Packaging] Bump MACOSX_DEPLOYMENT_TARGET to 12 instead of 11 #43137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 3, 2024

Rationale for this change

As shown on the associated issue there seems to be a problem with MACOSX_DEPLOYMENT_TARGET 11 on the wheels.

What changes are included in this PR?

Update MACOSX_DEPLOYMENT_TARGET everywhere to the latest supported macOS version.

Are these changes tested?

Via CI, even though the issue was not reproducible on CI.

Are there any user-facing changes?

Yes, wheels won't be available for macOS 11 but those were crashing on the previous release.

Copy link

github-actions bot commented Jul 3, 2024

⚠️ GitHub issue #41696 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 3, 2024
@raulcd
Copy link
Member Author

raulcd commented Jul 3, 2024

@github-actions crossbow submit wheel-macos-*

@raulcd
Copy link
Member Author

raulcd commented Jul 3, 2024

@github-actions crossbow submit verify-rc-source--macos-

Copy link

github-actions bot commented Jul 3, 2024

Revision: e239385

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9e99e37cf

Task Status
wheel-macos-monterey-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp38-amd64 GitHub Actions
wheel-macos-monterey-cp38-arm64 GitHub Actions
wheel-macos-monterey-cp39-amd64 GitHub Actions
wheel-macos-monterey-cp39-arm64 GitHub Actions

Copy link

github-actions bot commented Jul 3, 2024

Revision: e239385

Submitted crossbow builds: ursacomputing/crossbow @ actions-56448c3d06

Task Status
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-go-macos-amd64 GitHub Actions
verify-rc-source-go-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 3, 2024

@github-actions crossbow submit wheel-macos-monterey-cp310-amd64

Copy link

github-actions bot commented Jul 3, 2024

Revision: 93269ea

Submitted crossbow builds: ursacomputing/crossbow @ actions-f0354ef8a9

Task Status
wheel-macos-monterey-cp310-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 3, 2024

I am not sure why the linking error is happening:

FAILED: release/libarrow_flight.1700.0.0.dylib 
: && /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -fno-aligned-new  -Qunused-arguments -fcolor-diagnostics  -Wall -Wno-unknown-warning-option -Wno-pass-failed -msse4.2  -O3 -DNDEBUG -O2 -arch x86_64 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -mmacosx-version-min=12.0 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup   -compatibility_version 1700.0.0 -current_version 1700.0.0 -o release/libarrow_flight.1700.0.0.dylib -install_name @rpath/libarrow_flight.1700.dylib src/arrow/flight/CMakeFiles/arrow_flight_objlib.dir/Unity/unity_2_cxx.cxx.o src/arrow/flight/CMakeFiles/arrow_flight_objlib.dir/Unity/unity_1_cxx.cxx.o src/arrow/flight/CMakeFiles/arrow_flight_objlib.dir/Unity/unity_0_cxx.cxx.o  -Wl,-rpath,@loader_path  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libgrpc++.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libprotobuf.a  release/libarrow.1700.0.0.dylib  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libgrpc.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libz.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libcares.a  -lresolv  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libaddress_sorting.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libre2.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_marshalling.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_reflection.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_config.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_program_name.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_private_handle_accessor.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_commandlineflag.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_flags_commandlineflag_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_raw_hash_set.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_hashtablez_sampler.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_hash.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_city.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_low_level_hash.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_statusor.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libgpr.a  -lm  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_json.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_textformat.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_reflection.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_collections.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_mini_table.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_fastdecode.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_utf8_range.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libupb_extension_registry.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libdescriptor_upb_proto.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_bad_variant_access.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_status.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_strerror.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_distributions.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_seed_sequences.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_pool_urbg.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_randen.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_randen_hwaes.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_randen_hwaes_impl.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_randen_slow.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_platform.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_internal_seed_material.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_random_seed_gen_exception.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_cord.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_bad_optional_access.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_cordz_info.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_cord_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_cordz_functions.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_exponential_biased.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_cordz_handle.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_synchronization.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_graphcycles_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_kernel_timeout_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_stacktrace.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_symbolize.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_malloc_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_debugging_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_demangle_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_crc_cord_state.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_crc32c.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_str_format_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_crc_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_crc_cpu_detect.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_time.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_strings.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_strings_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_string_view.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_base.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_spinlock_wait.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_throw_delegate.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_int128.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_raw_logging_internal.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_log_severity.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_civil_time.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libabsl_time_zone.a  -Wl,-framework,CoreFoundation  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libssl.a  /Users/runner/work/crossbow/crossbow/vcpkg/installed/amd64-osx-static-release/lib/libcrypto.a  -framework CoreFoundation && :
ld: imageOffset32 fixup target must be defined

@raulcd raulcd changed the title GH-41696: [Python][Packaging] Bump MacOS Deployment Target to 12 instead of 11 GH-41696: [Python][Packaging] Bump MACOSX_DEPLOYMENT_TARGET to 12 instead of 11 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant