Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5314: [Go] Fix bug for FixedSizeBinary with offset #4334

Closed
wants to merge 1 commit into from

Conversation

alexandreyc
Copy link
Contributor

Same thing as #4307 but for FixedSizeBinary

@codecov-io
Copy link

Codecov Report

Merging #4334 into master will decrease coverage by 16.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4334       +/-   ##
===========================================
- Coverage   88.24%   72.19%   -16.06%     
===========================================
  Files         777       71      -706     
  Lines       97882     5944    -91938     
  Branches     1251        0     -1251     
===========================================
- Hits        86373     4291    -82082     
+ Misses      11273     1425     -9848     
+ Partials      236      228        -8
Impacted Files Coverage Δ
go/arrow/array/fixedsize_binary.go 74.41% <100%> (+0.6%) ⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
... and 697 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386a61e...c9e8477. Read the comment docs.

Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(ah! when #4307 hit the fan, true to my motto "bugs are like mushrooms, find one? look around, there should be many others", I immediately looked at array.Binary. but didn't think about FixedSizeBinary)

thanks!

@sbinet sbinet closed this in 66bebe4 May 17, 2019
@alexandreyc
Copy link
Contributor Author

I think it's worth a second pass to be sure we did not forget another :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants