Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5612: [Python][Doc] Add prominent note that date_as_object option changed with Arrow 0.13 #4381

Closed
wants to merge 3 commits into from

Conversation

mfcabrera
Copy link

Adding small documentation on bits on the pandas integration documentation. It relates to #4363
Not sure if the wording is correct.

@codecov-io
Copy link

Codecov Report

Merging #4381 into master will decrease coverage by 24.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4381       +/-   ##
===========================================
- Coverage   88.34%   63.78%   -24.57%     
===========================================
  Files         781      385      -396     
  Lines       98721    55678    -43043     
  Branches     1251        0     -1251     
===========================================
- Hits        87219    35514    -51705     
- Misses      11266    20164     +8898     
+ Partials      236        0      -236
Impacted Files Coverage Δ
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/extension_type.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/compare.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/json/chunker.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/filter.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/json/parser.h 0% <0%> (-100%) ⬇️
... and 592 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea6da3...0baf2a2. Read the comment docs.

@xhochy
Copy link
Member

xhochy commented May 26, 2019

I would think that these comments should rather go into the pandas documentation not. @jorisvandenbossche @wesm what do you think?

@jorisvandenbossche
Copy link
Member

The note about the change in default for dates might be useful here, but I agree that the note about parquet belongs more in the pandas docs.

It might be useful to add a note in the parquet section of the docs (so not the in the pandas section) that when you read the parquet file into a pandas dataframe (either through Table.to_pandas after reading the table or either with pd.read_parquet) the type conversion options are also related to the arrow -> pandas conversion options, and link to the pandas.rst "type differences" section about that.

@wesm wesm changed the title Document to_pandas behaviour before 0.13 and add extra pd related info [Python][Doc] Add prominent note that date_as_object option changed with Arrow 0.13 Jun 11, 2019
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I scrubbed out the bit which should go in the pandas documentation (@jorisvandenbossche, do you want to pick that up?) and fleshed out the warning about date_as_object in older versions of pyarrow

@jorisvandenbossche
Copy link
Member

(and taking up the pandas docs part)

@fsaintjacques fsaintjacques changed the title [Python][Doc] Add prominent note that date_as_object option changed with Arrow 0.13 ARROW-5612: [Python][Doc] Add prominent note that date_as_object option changed with Arrow 0.13 Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants