-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-5612: [Python][Doc] Add prominent note that date_as_object option changed with Arrow 0.13 #4381
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4381 +/- ##
===========================================
- Coverage 88.34% 63.78% -24.57%
===========================================
Files 781 385 -396
Lines 98721 55678 -43043
Branches 1251 0 -1251
===========================================
- Hits 87219 35514 -51705
- Misses 11266 20164 +8898
+ Partials 236 0 -236
Continue to review full report at Codecov.
|
I would think that these comments should rather go into the |
The note about the change in default for dates might be useful here, but I agree that the note about parquet belongs more in the pandas docs. It might be useful to add a note in the parquet section of the docs (so not the in the pandas section) that when you read the parquet file into a pandas dataframe (either through Table.to_pandas after reading the table or either with pd.read_parquet) the type conversion options are also related to the arrow -> pandas conversion options, and link to the pandas.rst "type differences" section about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I scrubbed out the bit which should go in the pandas documentation (@jorisvandenbossche, do you want to pick that up?) and fleshed out the warning about date_as_object
in older versions of pyarrow
(and taking up the pandas docs part) |
Adding small documentation on bits on the pandas integration documentation. It relates to #4363
Not sure if the wording is correct.