Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4823: [C++][Python] Do not close raw file handle in ReadaheadSpooler, check that file handles passed to read_csv are not closed #4610

Closed
wants to merge 1 commit into from
Closed

ARROW-4823: [C++][Python] Do not close raw file handle in ReadaheadSpooler, check that file handles passed to read_csv are not closed #4610

wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Jun 18, 2019

No description provided.

@wesm
Do not close raw file handle in ReadaheadSpooler and check that this …
5d13f23 
…flows through to fix reported issue with pyarrow.csv.read_csv
@wesm wesm requested a review from pitrou June 18, 2019 20:43
pitrou
pitrou approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Looks good to me.

@wesm wesm closed this in a155182 Jun 19, 2019
@asfimport asfimport mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wesm @pitrou