New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-5805: [Python] Dockerize (add to docker-compose) Python Travis CI job #4784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsaintjacques can you coordinate this patch with the one you just put up for the C++ build?
cython=0.29.7 | ||
cloudpickle | ||
hypothesis | ||
numpy>=1.14 | ||
pandas | ||
pytest | ||
pytest-faulthandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest=5.0
includes this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks
@wesm the On this subject, I think we should have most tests conda-less with system/bundled dependencies, and have a single CI entry test with conda (both C++ and python). This will be more reflective on how new developers and package maintainers experience the build. |
@fsaintjacques Yes I think that we should have a combined C++/Python docker-compose entry that uses dependencies from conda |
My suggestion also imply de-confa-ying the other images (since the base Note that this patch was initially implemented replacing cpp by removing conda, I ended up using |
Actually we should try to keep |
ed180da
to
85fe336
Compare
How would you all like to proceed with this patch? |
@wesm I'm doing a pretty heavy undertaking against the docker-compose.yml |
No problem. I was just scanning through the patch queue |
@kszucs I'd be happy to continue working on this, but I'm not clear on the direction: are we keeping conda here or not? Should we have a python image with conda and one without? |
Closing as this is superseded by the GitHub Actions patch |
This is to resolve ARROW-5805.