ARROW-5846: [Java] Create Avro adapter module and add dependencies #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
reviewed
Jul 4, 2019
java/adapter/avro/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.avro</groupId> | ||
| <artifactId>avro</artifactId> | ||
| <version>1.8.2</version> |
There was a problem hiding this comment.
I think 1.9 has been released?
There was a problem hiding this comment.
Yes, thanks for reminder, fixed now.
Codecov Report
@@ Coverage Diff @@
## master #4800 +/- ##
=========================================
+ Coverage 83.28% 89.6% +6.32%
=========================================
Files 277 661 +384
Lines 39642 96331 +56689
Branches 1418 0 -1418
=========================================
+ Hits 33015 86318 +53303
- Misses 6265 10013 +3748
+ Partials 362 0 -362Continue to review full report at Codecov.
|
emkornfield
reviewed
Jul 5, 2019
java/adapter/avro/pom.xml
Outdated
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
I don't think this will be necessary, since we won't be generating source filess?
|
+1, LGTM |
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Related to [ARROW-5846](https://issues.apache.org/jira/browse/ARROW-5846). Author: tianchen <niki.lj@alibaba-inc.com> Closes #4800 from tianchen92/ARROW-5846 and squashes the following commits: 8107847 <tianchen> fix 2 2c5ff66 <tianchen> fix de49b3a <tianchen> add test 79c04c8 <tianchen> update maven-compiler-plugin version d60cc8b <tianchen> update version 2a060fb <tianchen> ARROW-5846: Create Avro adapter module and add dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-5846.