Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-5865: [Release] Helper script to rebase PRs on master #4814

Closed
wants to merge 3 commits into from
Closed

ARROW-5865: [Release] Helper script to rebase PRs on master #4814

wants to merge 3 commits into from

Conversation

emkornfield
Copy link
Contributor

This make a script that will generate shell commands to force push all branchs.

@emkornfield
Copy link
Contributor Author

CC @kou

@emkornfield
Copy link
Contributor Author

Travis on my branch: https://travis-ci.org/emkornfield/arrow/builds/554767093?utm_medium=notification&utm_source=email

kou
kou requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This script will help us in the future releases!

dev/release/generate_force_push_script.py Outdated
response = client.getresponse()
json_content = response.read()
if response.status != 200:
error_msg = 'Github connection error:{}'.format(json_content)
Copy link
Member

@kou kou Jul 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "Github" -> "GitHub"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dev/release/generate_force_push_script.py Outdated Show resolved Hide resolved
dev/release/generate_force_push_script.py Outdated Show resolved Hide resolved
dev/release/generate_force_push_script.py Outdated Show resolved Hide resolved
dev/release/generate_force_push_script.py Outdated Show resolved Hide resolved
dev/release/generate_force_push_script.py Outdated Show resolved Hide resolved
kou
kou approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
We can try this in the next release and create dev/release/post-XXX.sh to automate this task.

@kou kou closed this in c2c9e99 Jul 6, 2019
kszucs pushed a commit that referenced this pull request Jul 22, 2019
@emkornfield @kszucs
ARROW-5865: [Release] Helper script to rebase PRs on master
3ea0a9e 
This make a script that will generate shell commands to force push all branchs.

Author: Micah Kornfield <emkornfield@gmail.com>

Closes #4814 from emkornfield/make_script_for_force_push and squashes the following commits:

ce9bf9a <Micah Kornfield> Adrress PR feedback
c4a14f5 <Micah Kornfield> fix flake8
033c870 <Micah Kornfield> ARROW-5865:  Helper script to rebase PRs on master
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emkornfield @kou