Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5997: [Java] Support dictionary encoding for Union type #4917

Closed
wants to merge 2 commits into from

Conversation

tianchen92
Copy link
Contributor

Related to ARROW-5997.

Now only Union type is not supported in dictionary encoding.
In the last several weeks, we did some refactor for encoding and now it's time to support Union type.

@codecov-io
Copy link

Codecov Report

Merging #4917 into master will increase coverage by 2.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4917      +/-   ##
=========================================
+ Coverage   87.46%   89.6%   +2.14%     
=========================================
  Files         994     660     -334     
  Lines      140389   96546   -43843     
  Branches     1418       0    -1418     
=========================================
- Hits       122785   86509   -36276     
+ Misses      17242   10037    -7205     
+ Partials      362       0     -362
Impacted Files Coverage Δ
cpp/src/arrow/json/converter.cc 90.53% <0%> (-1.78%) ⬇️
cpp/src/arrow/json/chunked-builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
... and 327 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe336...577b73c. Read the comment docs.

@kszucs kszucs force-pushed the master branch 2 times, most recently from ed180da to 85fe336 Compare July 22, 2019 19:29
@emkornfield
Copy link
Contributor

+1

pprudhvi pushed a commit to pprudhvi/arrow that referenced this pull request Aug 11, 2019
Related to [ARROW-5997](https://issues.apache.org/jira/browse/ARROW-5997).

Now only Union type is not supported in dictionary encoding.
In the last several weeks, we did some refactor for encoding and now it's time to support Union type.

Author: tianchen <niki.lj@alibaba-inc.com>

Closes apache#4917 from tianchen92/ARROW-5997 and squashes the following commits:

577b73c <tianchen> fix
e8a5889 <tianchen> ARROW-5997:  Support dictionary encoding for Union type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants