Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5998: [Java] Open a document to track the API changes #4918

Closed
wants to merge 1 commit into from

Conversation

liyafan82
Copy link
Contributor

We need a document to track the API behavior changes, so as not forget about them for the next release.

@codecov-io
Copy link

Codecov Report

Merging #4918 into master will increase coverage by 2.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4918      +/-   ##
=========================================
+ Coverage   87.46%   89.6%   +2.14%     
=========================================
  Files         994     660     -334     
  Lines      140389   96546   -43843     
  Branches     1418       0    -1418     
=========================================
- Hits       122785   86509   -36276     
+ Misses      17242   10037    -7205     
+ Partials      362       0     -362
Impacted Files Coverage Δ
cpp/src/arrow/json/converter.cc 90.53% <0%> (-1.78%) ⬇️
cpp/src/arrow/json/chunked-builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
... and 327 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe336...4c05293. Read the comment docs.

@tianchen92
Copy link
Contributor

Thanks for doing this @liyafan82, I also have several PRs introducing new APIs which I think should added into this file after this merged.

@liyafan82
Copy link
Contributor Author

Thanks for doing this @liyafan82, I also have several PRs introducing new APIs which I think should added into this file after this merged.

@tianchen92 thanks for your comments.
According to my understanding, this document should track APIs whose behaviors change. New APIs need not be included.

@emkornfield
Copy link
Contributor

Maybe we should just start the blog post doc for the next release early? @nealrichardson ?

@nealrichardson
Copy link
Contributor

I'm generally +100 for starting release announcements early--helps to make sure you ship something worth announcing. So I'd be in favor of that, though this seems more like a changelog that should exist separately anyway. Is there a convention for how/where to include changelogs with Java libraries? Seems like a useful thing to have, not just as a scratchpad for the next release announcement but to grow with the project.

@emkornfield
Copy link
Contributor

I thought change logs were generated from jira automatically?

@nealrichardson
Copy link
Contributor

For the release announcements, yeah they are autogenerated. I mean a human-curated running changelog specific for the Java library, for API changes and new features. Maybe that's not common in Java but it's standard practice in the R world (e.g. https://dplyr.tidyverse.org/news/), FWIW.

@wesm
Copy link
Member

wesm commented Jul 26, 2019

Maintaining this document could definitely grow onerous, though hopefully there aren't too many instances of breaking API changes that it becomes that way

@nealrichardson
Copy link
Contributor

I've found it more valuable than onerous in maintaining this "NEWS" file in my projects. It encourages you to communicate important user-facing changes to your library's users, and those are generally at a lower level than you'd want in an Apache Arrow project release announcement. Just my USD 0.02.

@emkornfield
Copy link
Contributor

+1 LGTM.

pprudhvi pushed a commit to pprudhvi/arrow that referenced this pull request Aug 11, 2019
We need a document to track the API behavior changes, so as not forget about them for the next release.

Closes apache#4918 from liyafan82/fly_0722_doc and squashes the following commits:

4c05293 <liyafan82>  Open a document to track the API changes

Authored-by: liyafan82 <fan_li_ya@foxmail.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants