ARROW-6079: [Java] Implement/test UnionFixedSizeListWriter for FixedSizeListVector #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4973 +/- ##
==========================================
+ Coverage 87.55% 89.71% +2.15%
==========================================
Files 1000 670 -330
Lines 142303 99543 -42760
Branches 1418 0 -1418
==========================================
- Hits 124589 89301 -35288
+ Misses 17352 10242 -7110
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
emkornfield
reviewed
Aug 9, 2019
| writeListVector(writer1, new int[] {7, 8, 9}); | ||
| writer1.setValueCount(3); | ||
|
|
||
| assertEquals(3, vector1.getValueCount()); |
There was a problem hiding this comment.
is there a way to avoid string comparison?
|
Seems mostly OK to me, not an expert on this area @praveenbingo do you have time to a take a look? |
praveenbingo
approved these changes
Aug 9, 2019
|
@tianchen92 - could you please re-trigger the tests, looks unrelated but just to be double sure. |
Sure, thank you. I also think it's unrelated since I only change the tests. |
|
@praveenbingo build passed :) |
|
+1, merging. Thank you @tianchen92 |
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
Aug 11, 2019
…izeListVector Related to [ARROW-6079](https://issues.apache.org/jira/browse/ARROW-6079). Now we have two list vectors: ListVector and FixedSizeListVector. ListVector has already implemented UnionListWriter for writing data, however, FixedSizeListVector doesn't have this yet and seems the only way for users to write data is getting inner vector and set value manually. Implement a writer for FixedSizeListVector is useful in some cases. Closes apache#4973 from tianchen92/ARROW-6079 and squashes the following commits: ad18d1c <tianchen> fix test to avoid string comparision d3338c7 <tianchen> ARROW-6079: Implement/test UnionFixedSizeListWriter for FixedSizeListVector Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6079.
Now we have two list vectors: ListVector and FixedSizeListVector.
ListVector has already implemented UnionListWriter for writing data, however, FixedSizeListVector doesn't have this yet and seems the only way for users to write data is getting inner vector and set value manually.
Implement a writer for FixedSizeListVector is useful in some cases.